all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 15682@debbugs.gnu.org
Subject: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link'
Date: Sun, 25 Aug 2019 07:47:02 +0200	[thread overview]
Message-ID: <8736hpajah.fsf@gnus.org> (raw)
In-Reply-To: <CABczVwcKzVDBq+-SSerWF77ugjBM2en-nV4potZ+jqPKD2QY8g@mail.gmail.com> (Mauro Aranda's message of "Fri, 23 Aug 2019 17:41:45 -0300")

Mauro Aranda <maurooaranda@gmail.com> writes:

> The attached patch tries to fix this bug, while trying to not change
> too much of the code of the widget library.  It introduces a keymap
> for the link widgets, and only binds mouse-2 events.  Since
> widget-button-click isn't changed, it has to bind down-mouse-2 too.
> In this fix, I also have been careful to not reintroduce bugs that
> have come up by changing the keybindings in the widget-keymap, such as
> here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23571

I think this makes sense.

> I investigated the emacs sources, and have noticed that this patch could cause
> problems with three pieces of code:

Would it be possible for you to come up with patches for fixing these
three pieces, too?  And then we could apply all four patches at the same
time and not break anything.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-08-25  5:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 15:28 bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' Drew Adams
2016-04-27 16:09 ` bug#52: " Lars Ingebrigtsen
2016-04-27 16:24   ` Drew Adams
2016-04-27 16:53     ` bug#52: " Lars Ingebrigtsen
2016-04-27 17:18       ` Drew Adams
2019-08-23 20:41 ` Mauro Aranda
2019-08-25  5:47   ` Lars Ingebrigtsen [this message]
2019-08-25 15:07     ` Mauro Aranda
2019-08-25 16:19       ` Drew Adams
2019-08-25 16:22         ` Drew Adams
2019-08-25 16:41           ` Eli Zaretskii
2019-08-25 16:50           ` Noam Postavsky
2019-08-25 16:58             ` Mauro Aranda
2019-08-27  6:42       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736hpajah.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=15682@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.