From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: Oas: a small addon to Org Mode to automatically close tasks with statistics
Date: Sun, 01 Sep 2019 00:41:40 -0500 [thread overview]
Message-ID: <8736hglgiz.fsf@alphapapa.net> (raw)
In-Reply-To: VI1PR06MB5214DE61F4E6E5559073E305C7BD0@VI1PR06MB5214.eurprd06.prod.outlook.com
Hi Andrea,
This is a nice idea. Here are a few notes:
1. You should implement it as a minor mode, and enable/disable the
hooks there.
2. I would generally recommend using org-element to help with parsing.
It will make your code much cleaner and easier to understand. Much of
the searching code you currently have is unidiomatic and hard to follow,
and org-element will help with that.
3. Avoid using hard-coded to-do keywords, because users may be using
custom ones. Instead, use the variables and functions provided by Org
that are related to to-do keywords. Use tools like apropos, Helm, or
Counsel, or the Org source code, to help discover them.
next prev parent reply other threads:[~2019-09-01 5:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 21:09 Oas: a small addon to Org Mode to automatically close tasks with statistics Andrea Giugliano
2019-09-01 5:41 ` Adam Porter [this message]
2019-10-07 2:03 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736hglgiz.fsf@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.