all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Damien Cassou <damien@cassou.me>
To: 37470@debbugs.gnu.org
Subject: bug#37470: 26.3; [PATCH] Default value and type of message-make-forward-subject-function
Date: Fri, 20 Sep 2019 11:08:42 +0200	[thread overview]
Message-ID: <8736grwd0l.fsf@cassou.me> (raw)

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

Please find attached a patch fixing the default value and type of
message-make-forward-subject-function.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Change-default-value-of-message-make-forward-subject.patch --]
[-- Type: text/x-patch, Size: 1919 bytes --]

From f50141be18a15233d45069484b004492b2956cf9 Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Fri, 20 Sep 2019 11:04:26 +0200
Subject: [PATCH] Change default value of message-make-forward-subject-function

* lisp/gnus/message.el (message-make-forward-subject-function): Change
default value to be a list so it's easier for users to add
functions. Change the type so the customize interface allows selecting
multiple provided functions instead of just one.
---
 lisp/gnus/message.el | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 48d79107ea..3d0d7bc631 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -532,7 +532,7 @@ message-user-organization-file
   :group 'message-headers)
 
 (defcustom message-make-forward-subject-function
-  #'message-forward-subject-name-subject
+  (list #'message-forward-subject-name-subject)
   "List of functions called to generate subject headers for forwarded messages.
 The subject generated by the previous function is passed into each
 successive function.
@@ -547,10 +547,11 @@ message-make-forward-subject-function
       to it."
   :group 'message-forwarding
   :link '(custom-manual "(message)Forwarding")
-  :type '(radio (function-item message-forward-subject-author-subject)
-		(function-item message-forward-subject-fwd)
-		(function-item message-forward-subject-name-subject)
-		(repeat :tag "List of functions" function)))
+  :type '(repeat :tag "List of functions"
+                 (radio (function-item message-forward-subject-author-subject)
+                        (function-item message-forward-subject-fwd)
+                        (function-item message-forward-subject-name-subject)
+                        (function))))
 
 (defcustom message-forward-as-mime nil
   "Non-nil means forward messages as an inline/rfc822 MIME section.
-- 
2.21.0


             reply	other threads:[~2019-09-20  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  9:08 Damien Cassou [this message]
2019-09-20 10:02 ` bug#37470: 26.3; [PATCH] Default value and type of message-make-forward-subject-function Robert Pluim
2019-09-20 10:22   ` Damien Cassou
2019-09-20 12:14     ` Robert Pluim
2019-09-20 17:28 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736grwd0l.fsf@cassou.me \
    --to=damien@cassou.me \
    --cc=37470@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.