all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Michał Krzywkowski" <mkrzywkow@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37892@debbugs.gnu.org, "Michał Krzywkowski" <mkrzywkow@gmail.com>
Subject: bug#37892: 27.0.50; Crash when signaling a thread
Date: Sun, 27 Oct 2019 20:26:43 +0100	[thread overview]
Message-ID: <8736feyop8.fsf@zoho.com> (raw)
In-Reply-To: <83r22ys4kh.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]


>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
    Eli> But thread-signal is not for causing an error in a thread, it is for
    Eli> unblocking a thread that waits on a mutex or a condvar.  So why would
    Eli> you use it when the thread is not blocked?
    >>
    >> Then I think documentation for that function should be changed to
    >> explicitly say that the signal will *only* be delivered if the target
    >> thread is in a "blocked call to ‘mutex-lock’, ‘condition-wait’, or
    >> ‘thread-join’".
    >>
    >> Currently, the docstring of thread-signal just says that the function
    >> will interrupt threads which are blocked, but does not actually say that
    >> the signal will be delivered only in those cases.  In fact, it says that
    >> it works like signal, so I don't think it's unreasonable to assume that
    >> it will just interrupt a thread whatever it's doing.

    Eli> The function does work like a signal, but Emacs cannot be interrupted
    Eli> while it waits for input.  In all other cases your signal will be
    Eli> delivered, and if unhandled, it will terminate the thread.

    Eli> If we decide that thread-signal will have no effect while a thread
    Eli> waits for input, then we will document that, of course.  My question
    Eli> was meant to understand your intent for signaling a thread at
    Eli> arbitrary time, because the effect of that is unpredictable, even if
    Eli> the crash didn't happen.  I wanted to understand your thinking and
    Eli> rationale, so as to have a better basis for the decision of how to fix
    Eli> this problem.

    Eli> So could you please elaborate on your rationale?

Actually there is no deeper reason behind it.  I was just testing
threads in Emacs, seeing how things behave.  I certainly would think
twice before writing code that interrupts a thread at an arbitrary point
in a real program.

When it comes to sit-for, I use it sometimes.  Is there a reason not to
use it in threads?

In any case, I'm not encouraging anyone to program like that, I'm just
reporting a crash...

--
Michał Krzywkowski
PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-10-27 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 17:06 bug#37892: 27.0.50; Crash when signaling a thread Michał Krzywkowski
2019-10-25  8:44 ` Eli Zaretskii
2019-10-26 12:29   ` Michał Krzywkowski
2019-10-26 12:58     ` Eli Zaretskii
2019-10-27 10:16       ` Michał Krzywkowski
2019-10-27 13:25         ` Eli Zaretskii
2019-10-27 19:26           ` Michał Krzywkowski [this message]
2021-12-05  3:15 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736feyop8.fsf@zoho.com \
    --to=mkrzywkow@gmail.com \
    --cc=37892@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.