From: Juri Linkov <juri@linkov.net>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: 39597@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#39597: 27.0.60: M-x occur adds fontification to fundamental-mode
Date: Tue, 18 Feb 2020 02:12:32 +0200 [thread overview]
Message-ID: <8736b8eosv.fsf@mail.linkov.net> (raw)
In-Reply-To: <87imk960qb.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Fri, 14 Feb 2020 09:18:20 +0100")
> I think commit fb16313025 (2018-12-18T23:10:09Z!juri@linkov.net) had an
> unintended side-effect on fundamental-mode. From emacs -Q:
This commit contains this change:
diff --git a/lisp/replace.el b/lisp/replace.el
index dcae12e9b7..b8f231eb55 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1907,10 +1907,8 @@ occur-engine
global-matches)))
(defun occur-engine-line (beg end &optional keep-props)
- (if (and keep-props (if (boundp 'jit-lock-mode) jit-lock-mode)
- (text-property-not-all beg end 'fontified t))
- (if (fboundp 'jit-lock-fontify-now)
- (jit-lock-fontify-now beg end)))
+ (if (and keep-props font-lock-mode)
+ (font-lock-ensure beg end))
(if (and keep-props (not (eq occur-excluded-properties t)))
(let ((str (buffer-substring beg end)))
(remove-list-of-text-properties
> - C-x b repro RET
> - foo RET "bar" RET baz
> - M-s o . RET
>
> In emacs 26.3, the Occur buffer pops up and not much else happens;
> starting with emacs 27, font-lock-string-face is applied to "bar".
>
> I haven't dug much more than that; FWIW however, emacs 26.3 already
> applied font-lock-string-face to double-quoted strings when running
> (font-lock-ensure) in a fundamental buffer, so maybe the right fix
> belongs e.g. somewhere in font-lock-set-defaults?
Stefan, could you suggest what to do with font-lock-ensure
to not highlight double-quoted strings in fundamental-mode?
next prev parent reply other threads:[~2020-02-18 0:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 8:18 bug#39597: 27.0.60: M-x occur adds fontification to fundamental-mode Kévin Le Gouguec
2020-02-18 0:12 ` Juri Linkov [this message]
2020-02-18 13:51 ` Stefan Monnier
2020-02-18 22:49 ` Juri Linkov
2020-02-20 14:54 ` Eli Zaretskii
2020-02-20 19:10 ` Kévin Le Gouguec
2020-02-20 19:58 ` Eli Zaretskii
2020-02-20 22:27 ` Kévin Le Gouguec
2020-02-21 7:40 ` Eli Zaretskii
2020-02-21 19:09 ` Kévin Le Gouguec
2020-02-23 0:24 ` Juri Linkov
2020-02-25 20:45 ` Kévin Le Gouguec
2020-02-23 0:37 ` Juri Linkov
2020-02-21 0:04 ` Juri Linkov
2020-02-19 18:57 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736b8eosv.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=39597@debbugs.gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.