From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Date: Sun, 12 Apr 2020 16:13:23 +0200 Message-ID: <873698dc70.fsf@gmail.com> References: <20200308090630.41238-1-stepnem@gmail.com> <87pndf17v5.fsf@gnus.org> <87zhcinbdl.fsf@gmail.com> <87d09ezudv.fsf@gnus.org> <83zhciby6s.fsf@gnu.org> <87imioo963.fsf@gmail.com> <875zeinoc0.fsf@gnus.org> <87wo6lc9n8.fsf@gmail.com> <83blnxkn7i.fsf@gnu.org> <87o8rxc72a.fsf@gmail.com> <83a73hklq3.fsf@gnu.org> <87k12lc4dz.fsf@gmail.com> <838sj0lt72.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90590"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, 39980@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 12 16:13:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNdMG-000NSC-8J for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 16:13:12 +0200 Original-Received: from localhost ([::1]:33822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNdMF-0003pl-AI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 10:13:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60944) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNdM7-0003nx-FA for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNdM6-0002Wr-Ir for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47072) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNdM6-0002Wl-Fx for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNdM6-0001V9-BX for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Apr 2020 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39980-submit@debbugs.gnu.org id=B39980.15867007775759 (code B ref 39980); Sun, 12 Apr 2020 14:13:02 +0000 Original-Received: (at 39980) by debbugs.gnu.org; 12 Apr 2020 14:12:57 +0000 Original-Received: from localhost ([127.0.0.1]:58617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdM1-0001Up-7Y for submit@debbugs.gnu.org; Sun, 12 Apr 2020 10:12:57 -0400 Original-Received: from mail-lj1-f176.google.com ([209.85.208.176]:45539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdLz-0001Ub-0u for 39980@debbugs.gnu.org; Sun, 12 Apr 2020 10:12:56 -0400 Original-Received: by mail-lj1-f176.google.com with SMTP id t17so6348340ljc.12 for <39980@debbugs.gnu.org>; Sun, 12 Apr 2020 07:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=NYnSxg1CMnqrKodx+Xgvs9A76DkVHeHGYnwIrWrE6tw=; b=kWDlkg4bH71OvudTNe9Xye7kofK8Fne97k/SRWNufldXn6sIfBK9hreXLTDki2tSSs p21YDyCxcrG1j3uVJIVUQhNpN/Ip0RUMsFNyI1wAhGZBPGEQuU7i0GlNxa37JesJ6vhc CwZP6tWB/3uCYgXg9Nwjbz52cRfuX5cHVZHc3ej6X4hfXLSxcGMblFJVvKXpWJrneF1x BQtfM7I8SIysOQ14DrF/nCG7dVRNdzGGzmwxwAvQxOvuHwG2YSmWqJAnCwaM5yHjWS8t V/Mn5chT2dxgM0C8MDxQaqj2wQ7FX+XryT91RohOzb0r57l85fltO+8F9PBnV/OD14zT 2o/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=NYnSxg1CMnqrKodx+Xgvs9A76DkVHeHGYnwIrWrE6tw=; b=POKyD27Nwoi9g/3i4b42dUr2hHB9PW12EI3p8hE66Gvh62D07iwUotbnCv+J2S0dNa Qz+CtSuS0HDP/CRm9wSe5QS2yrblq5o88YvRGlH9Al/VBtI1SqyBKvS+dasxo5RvDbDp bzsf7a8X7oYVrPsvzrcAKwE3Gp0IhGuJnO7a57v7UBfM5RGD5YEyfWlpGckRA8eBoX2t oTQBTuWWsru+IWY+aTeb/7ZnJ5S0ETVoNNhr0s9uuH/fB8PeI6iGE9TX6XcsPf9XJIwd 6Xt/8dLcLdTvghroRwpTfcbjzSaxBlSsYNwbIaQ6LjgEBMOmyhUpDYN+g5LM3sz79fUL mPfA== X-Gm-Message-State: AGi0Pubdbm9hqo4StICkOLhX62P+NSLfgBONxKRTsRNwkJ9zJcgugwRK mIc7H2U+Zyt2fVheBl3mqoA= X-Google-Smtp-Source: APiQypIjaN3C5Zpt8rCHGA7FGpjSQLbQgPnU3jQAL7bB+zkNM7wxKgsxd27RxPpr/E8xxZbhZ8MQsg== X-Received: by 2002:a2e:9a87:: with SMTP id p7mr8063299lji.61.1586700768990; Sun, 12 Apr 2020 07:12:48 -0700 (PDT) Original-Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id r21sm5530692ljp.29.2020.04.12.07.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2020 07:12:48 -0700 (PDT) In-Reply-To: <838sj0lt72.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Apr 2020 16:38:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178247 Archived-At: On Sun, 12 Apr 2020 16:38:57 +0300 Eli Zaretskii wrote: >> You mean instead of reusing an existing function, fix `gnus-shorten-url' >> without using it? > > Almost: the "existing function" doesn't really exist, you introduced > it with the same changeset, right? No, it's the (hopefully) tried and true `ediff-truncate-string-left', only renamed and moved to subr-x to be generally available. The changes are cosmetic. It would even be possible (in emacs-27, to avoid moving anything), to use `ediff-truncate-string-left' unchanged, but that would require gnus-sum to (require 'ediff-init), which would be crazy. Or make `ediff-truncate-string-left' a defsubst instead of defun and (eval-when-compile (require 'ediff-init)) in gnus-sum. That should actually work :-P > Both variants of the log message are fine. Thanks. --=20 =C5=A0t=C4=9Bp=C3=A1n