From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode' Date: Sat, 23 May 2020 22:31:06 +0200 Message-ID: <87367qmm0l.fsf@gmail.com> References: <87lfpu9ag8.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="33135"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39293@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 23 22:32:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcaoT-0008WA-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 22:32:09 +0200 Original-Received: from localhost ([::1]:37694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcaoS-0003q0-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 16:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcaoM-0003pr-Cb for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 16:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcaoM-0004cH-3x for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcaoM-0004gc-0q for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2020 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39293-submit@debbugs.gnu.org id=B39293.159026587617960 (code B ref 39293); Sat, 23 May 2020 20:32:01 +0000 Original-Received: (at 39293) by debbugs.gnu.org; 23 May 2020 20:31:16 +0000 Original-Received: from localhost ([127.0.0.1]:35811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcanc-0004fc-7r for submit@debbugs.gnu.org; Sat, 23 May 2020 16:31:16 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:53342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcana-0004fO-FN for 39293@debbugs.gnu.org; Sat, 23 May 2020 16:31:14 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id u1so11909164wmn.3 for <39293@debbugs.gnu.org>; Sat, 23 May 2020 13:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=g6gzbb7oEhdJNdlSvXBfBpI0ljQS5YQ2lINsFgFf//4=; b=Re5cZNRpoboUbi/wd+Oyqeem1Uht3xk59RSTZr2ROSRsIaHzfURqazJnYpaOKt6lvY g6gt4JBro/nNYkImS3SSKrPwp3UVEVsZ/QGb8BD1V0wR1Vc9XdC+dYdHfMBniTrmA8ya M5o68Cm/7CJUNMqlFtQ6dD0TSc8oHg30UTOKG76kICqNH1z5WkMf3jemoLdmuIOvJXQ7 lzdarHP9vAzgQmcS8P4691lt7nrW7vuo9pGJx0Timx61FIr1qB1E4Abgp3cJSiIZQ3lB ZAVoyVouj4M1tY3pka76EyCjLq8j9a56Qz6uc4aHmFu3iLv/trhQ9guvKwzNT0Z5m+t4 tbhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=g6gzbb7oEhdJNdlSvXBfBpI0ljQS5YQ2lINsFgFf//4=; b=mvR5Wi/ZtoKWBek5F+xYhXd79ziiNx0IGmA13lnOkJAzyuz7JFKkjqy0ryU61WXF6l 0izg/Ok0pBuEMILKDk0gomlFeP8+xnODVAMkO0ZA+hRFWFgr0mB7H5Vu3yAloUUsgPKn 4hrkA3APOAaX7tinllb6KZfvXPGqLgCGad9MtFFzHNOkNAim0OYcb6n9lTJ43u/hsd6r 1UAmnkjr+z7eziVftJnnmkOUuGhLXV1YuRg3Ry4wjeTSV2N0I/1hvoryWtknvgTy2o5i DY78/0fDPTL+xVwYBcT1k8/w/+qy26nMxvK/8IorM9SjKqqjcGL2LWG/h4MKrrk/s+zJ vIng== X-Gm-Message-State: AOAM530NGo+wHF4f6qS3gWBGyDzAvxhtDDGSjbLnJ4BoqncycEXC8etT Zoo8eXMu4ANF/+ffQe5wxyhbbRaSwpI= X-Google-Smtp-Source: ABdhPJwdQp3t7P8hixfoRiV64fnK/XIdzLzl/CDbR8Sh78MvLHZRSkXOvgN3OPkUk3Vi3ctML7AyNA== X-Received: by 2002:a1c:a901:: with SMTP id s1mr3280729wme.66.1590265868294; Sat, 23 May 2020 13:31:08 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:252:7910:679d:a1d5:8917:cc97]) by smtp.gmail.com with ESMTPSA id a6sm4063397wrn.38.2020.05.23.13.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 13:31:07 -0700 (PDT) In-Reply-To: <87lfpu9ag8.fsf@marxist.se> (Stefan Kangas's message of "Sun, 26 Jan 2020 04:13:27 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180847 Archived-At: Stefan Kangas writes: > The attached patch changes bookmark-bmenu-mode to be based on > tabulated-list-mode instead of special-mode. > > This allows us to simplify the code in several cases. In > addition, we get many features for free, such as sorting columns > by clicking on the column headers, changing size of columns. Both features looks interesting to me. Thanks for working on that! > In the future, this will obviously include any new feature added > to 'tabulated-list-mode'. > > The only functional step backwards is that we no longer support > the optional "inline" header line -- a bookmark.el-specific hack > to have a header without using 'header-line-format'. I don't > believe this feature is very useful since the lack of such > support for anything similar in e.g. 'package-menu-mode' has not > caused any problems. It seems to have been added together with > 'header-line-format' as a fire escape if the latter caused any > problems. I am the one who introduced `header-line-format` in bookmark.el (7a78e19f24) and I confirm that I kept the legacy header "just in case". The new behavior has been enabled by default since 2013, and I've not heard any complaint. -- Matthias Meulien