bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Gregor Zattler]

Dear emacs developers,

I get an assertion error when executing the following line
(from a cron job of mine):

grfz@no:~/src$ find ~/src -type f -print0 | egrep -zZ '(\.el|\.c|\.h)(\.gz)?$' | xargs -0r etags
etags: etags.c:1987: pfnote: Assertion `name == NULL || name[0] != '\0'' failed.
xargs: etags: terminated by signal 6
125 (master *) grfz@no:~/src$

This happens with etags from debian buster, as with etags
build from emacs-27 branch of emacs git repo, as with etags build
from feature/native-comp branch.


Under ~/src there is also the linux kernel git repo.  There
is no assertion error if I filter it out:

$ find . -type f -print0 | egrep -vzZ linux | egrep -zZ '(\.el|\.c|\.h)(\.gz)?$' | xargs -0r etags
0 (master *) grfz@no:~/src$

There is also no assertion error if I filter for .el files
only:

125 (master *) grfz@no:~/src$ find ~/src -type f -print0 | egrep -zZ '(\.el)(\.gz)?$' | xargs -0r etags
0 (master *) grfz@no:~/src$


Therefore I assume this somehow is related to the number of files.


Ciao; Gregor
--
 -... --- .-. . -.. ..--.. ...-.-

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Dmitry Gutov]

Hi!

On 22.05.2020 22:31, Gregor Zattler wrote:
> Dear emacs developers,
> 
> I get an assertion error when executing the following line
> (from a cron job of mine):
> 
> grfz@no:~/src$ find ~/src -type f -print0 | egrep -zZ '(\.el|\.c|\.h)(\.gz)?$' | xargs -0r etags
> etags: etags.c:1987: pfnote: Assertion `name == NULL || name[0] != '\0'' failed.
> xargs: etags: terminated by signal 6
> 125 (master *) grfz@no:~/src$

Looking at the code, it seems more likely the problem is because we're 
failing to parse some particular piece of code.

So if you can determine which file fails to parse, and send us an 
example, that should help fix it.

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Dmitry Gutov]

On 23.05.2020 11:34, Gregor Zattler wrote:
> I attach these two files.

Thank you. But I couldn't reproduce the error.

Do you get the same result if you run

   etags cs43130.c mac80211.h

?

Are you sure this executable came from the Emacs tree? If you have a 
checkout of that development tree, can you run it from there? E.g.

   path/to/emacs/lib-src/emacs cs43130.c mac80211.h

?

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Gregor Zattler]

Hi Dmitry,
* Dmitry Gutov <dgutov@yandex.ru> [2020-05-23; 23:22]:
> On 23.05.2020 11:34, Gregor Zattler wrote:
>> I attach these two files.
>
> Thank you. But I couldn't reproduce the error.
>
> Do you get the same result if you run
>
>    etags cs43130.c mac80211.h
>
> ?
>
> Are you sure this executable came from the Emacs tree? If you have a
> checkout of that development tree, can you run it from there? E.g.
>
>    path/to/emacs/lib-src/emacs cs43130.c mac80211.h

I did it again:

0 (master *) grfz@no:~/.cron.daily$ ~/src/emacs/lib-src/etags ~/src/linux/sound/soc/codecs/cs43130.c
etags: etags.c:1988: pfnote: Assertion `name == NULL || name[0] != '\0'' failed.
Aborted
134 (master *) grfz@no:~/.cron.daily$ /usr/bin/etags ~/src/linux//include/net/mac80211.h
etags: etags.c:1987: pfnote: Assertion `name == NULL || name[0] != '\0'' failed.
Aborted
134 (master *) grfz@no:~/.cron.daily$


This also happens with the binary from debian buster 10.4 ,
therefore I don't think it is caused by my specific build
options, which anyway are:

CFLAGS='-g -O2 -fdebug-prefix-map=/home/grfz/src/emacs=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -fno-pie'

LDFLAGS='-Wl,-z,relro -no-pie'

CPPFLAGS='-Wdate-time -D_FORTIFY_SOURCE=2  '

./configure -C --prefix=/usr/local/stow/emacs-snapshot --with-file-notification=inotify --with-cairo --without-toolkit-scroll-bars --with-x-toolkit=gtk3 --with-sound=yes --without-gconf --with-mailutils --with-x=yes --enable-checking=yes --enable-check-lisp-object-type=yes --with-nativecomp


For me this assertion error is not a big problem since I now
exclude the linux src tree from the tags creation because of
emacs performance reasons.

Ciao; Gregor
--
 -... --- .-. . -.. ..--.. ...-.-

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Dmitry Gutov]

On 24.05.2020 02:07, Gregor Zattler wrote:
> This also happens with the binary from debian buster 10.4 ,
> therefore I don't think it is caused by my specific build
> options, which anyway are:
> 
> CFLAGS='-g -O2 -fdebug-prefix-map=/home/grfz/src/emacs=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -fno-pie'
> 
> LDFLAGS='-Wl,-z,relro -no-pie'
> 
> CPPFLAGS='-Wdate-time -D_FORTIFY_SOURCE=2  '
> 
> ./configure -C --prefix=/usr/local/stow/emacs-snapshot --with-file-notification=inotify --with-cairo --without-toolkit-scroll-bars --with-x-toolkit=gtk3 --with-sound=yes --without-gconf --with-mailutils --with-x=yes --enable-checking=yes --enable-check-lisp-object-type=yes --with-nativecomp
> 
> 
> For me this assertion error is not a big problem since I now
> exclude the linux src tree from the tags creation because of
> emacs performance reasons.

Thanks you for that addition.

Indeed, when I configure Emacs with

   CFLAGS='-g -O2' --enable-checking

etags does abort with assertion errors you described.

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Dmitry Gutov]

Hi Gregor,

Please keep the bug email in Cc.

On 24.05.2020 09:58, Gregor Zattler wrote:
> Hi Dmitry,
> * Dmitry Gutov <dgutov@yandex.ru> [2020-05-24; 04:43]:
>> Thanks you for that addition.
>>
>> Indeed, when I configure Emacs with
>>
>>     CFLAGS='-g -O2' --enable-checking
>>
>> etags does abort with assertion errors you described.
> 
> arghs, my statement "also happens with the binary from
> debian buster 10.4" was wrong.  I tested with /usr/bin/etags
> but forgot I that wrestled my emacs-27 build into the
> alternatives system of debian.
> 
> I tested again with
> 
> 0 (master *) grfz@no:~$ /usr/bin/etags.emacs ~/src/linux//include/net/mac80211.h
> 0 (master *) grfz@no:~$ /usr/bin/etags.emacs ~/src/linux/sound/soc/codecs/cs43130.c
> 
> and now there are no assertion errors with these files.

Makes sense.

> But shouldn't there also be no assertion errors with
> --enable-checking ?

There shouldn't be.

So it's a valuable bug report, just less urgent than we might have 
decided previously.

I'll let our developers who know etags better handle it from here.

bug#41465: 28.0.50 (but also earlier versions); etags asserion error (with too many files?)

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sun, 24 May 2020 04:43:25 +0300
> 
> > For me this assertion error is not a big problem since I now
> > exclude the linux src tree from the tags creation because of
> > emacs performance reasons.
> 
> Thanks you for that addition.
> 
> Indeed, when I configure Emacs with
> 
>    CFLAGS='-g -O2' --enable-checking
> 
> etags does abort with assertion errors you described.

Thanks, I applied the trivial band-aid to fix this on the emacs-27
branch.