Re: [PATCH] Improve Malayalam language transliteration

[James Thomas <jimjoe@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

Please consider this new patch (to my own code) which uses strings
rather than (expensive) lists to represent constant char sequences.

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, I pushed this to the master branch.


[-- Attachment #2: 0001-indian-mlm-mozhi-update-translation-Use-strings-for-.patch --]
[-- Type: text/x-diff, Size: 2521 bytes --]

From 7e3007d5d08384e7c4c2e93d6e20ab4fc435d3fd Mon Sep 17 00:00:00 2001
From: James Thomas <jimjoe@gmx.net>
Date: Wed, 15 Jul 2020 17:29:08 +0530
Subject: [PATCH] indian-mlm-mozhi-update-translation: Use strings for constant
 sequences

* lisp/leim/quail/indian.el (indian-mlm-mozhi-update-translation):
Use strings rather than lists for constant sequences.
Copyright-paperwork-exempt: yes
---
 lisp/leim/quail/indian.el | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/lisp/leim/quail/indian.el b/lisp/leim/quail/indian.el
index 100ae63f6a..e1322ddc1e 100644
--- a/lisp/leim/quail/indian.el
+++ b/lisp/leim/quail/indian.el
@@ -576,18 +576,18 @@ "X"
 
 (defun indian-mlm-mozhi-update-translation (control-flag)
   (let ((len (length quail-current-key)) chillu
-	(vowels '(?a ?e ?i ?o ?u ?A ?E ?I ?O ?U ?R)))
+	(vowels "aeiouAEIOUR"))
     (cond ((numberp control-flag)
 	   (progn (if (= control-flag 0)
 		      (setq quail-current-str quail-current-key)
 		    (cond (input-method-exit-on-first-char)
-			  ((and (memq (aref quail-current-key
-					    (1- control-flag))
-				      vowels)
+			  ((and (cl-find (aref quail-current-key
+					       (1- control-flag))
+				         vowels)
 				(setq chillu (cl-position
 					      (aref quail-current-key
 						    control-flag)
-					      '(?m ?N ?n ?r ?l ?L))))
+					      "mNnrlL")))
 			   ;; conditions for putting chillu
 			   (and (or (and (= control-flag (1- len))
 					 (not (setq control-flag nil)))
@@ -606,7 +606,7 @@ indian-mlm-mozhi-update-translation
 						  (string quail-current-str)
 						quail-current-str)
 					      (string
-					       (nth chillu '(?ം ?ൺ ?ൻ ?ർ ?ൽ ?ൾ)))))))))
+					       (aref "ംൺൻർൽൾ" chillu))))))))
 		  (and (not input-method-exit-on-first-char) control-flag
 		       (while (> len control-flag)
 			 (setq len (1- len))
@@ -619,8 +619,8 @@ indian-mlm-mozhi-update-translation
 	     (setq quail-current-str quail-current-key)
 	     ))
 	  ((equal control-flag t)
-	   (if (memq (aref quail-current-key (1- len))  ;; If vowel ending,
-		     vowels)                            ;; may have to put
+	   (if (cl-find (aref quail-current-key (1- len));; If vowel ending,
+		        vowels)                          ;; may have to put
 	       (setq control-flag nil)))))              ;; chillu. So don't
   control-flag)                                         ;; end translation
 
-- 
2.25.1