From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 4d00db5 8/8: Remove compat code from comint.el Date: Wed, 12 Aug 2020 08:29:59 +0100 Message-ID: <87364sgw3s.fsf@tcd.ie> References: <20200811190418.24261.58579@vcs0.savannah.gnu.org> <20200811190422.0409E20CB8@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14904"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 12 09:30:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5lDd-0003mI-57 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 09:30:41 +0200 Original-Received: from localhost ([::1]:53438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5lDc-0006ZZ-6G for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 03:30:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5lD4-00064q-IA for emacs-devel@gnu.org; Wed, 12 Aug 2020 03:30:06 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:34385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5lD2-0007ti-Fg for emacs-devel@gnu.org; Wed, 12 Aug 2020 03:30:06 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id f7so1074790wrw.1 for ; Wed, 12 Aug 2020 00:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N3s7gncp2mHqRtpuS482nokY+VOrbpJw20zoYcdyosY=; b=MDvSRBWNuPvfQjO34HxNGrHxLypRqyO8j/dTSy1QBpvnlGDbxa2Fv9w3/KKlE4xRVp oiI7by3jKbij9PV6cQVeRs4WhFUL0yi2rQmp8R/VG9qAGDD77b3TdScryMIHXWMy0xRs SEb32h18DeUy7/I8Fu4CX1YALIlWlOzAu0Dt7LS78kFwSrXTxYi6fNm7K54Ostwrdc4p 1GNup1ljoC91J9NMbaG3aDNba46WXIN7nUUD4O+5hOzbAwRPNzyYO5nVcuuewrfP568l 4KtQbp9u0lh+B6jhw1KCazpY3wSrs1QTIUFkK8mWAAuzR6vxwF+QqPYZNESkN4/El056 aLaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N3s7gncp2mHqRtpuS482nokY+VOrbpJw20zoYcdyosY=; b=Hr4RXVDYsU1YGWqirSH3CNUhpVaLtjADMQm/KvoGs1ICjdTkNPTR2LJ1zYgY+DanDl ma9Le6olBoc6oYEsIL3kAMcn2nkwp3hIulUzEkgtOmfvVx7q4sRPXFVJLCD8414LI1cQ iNF6cyOsvZeSk19y8xH4iSpteqgo4sA8a36BrqZuckzs3bfSpcFBRn0H2K6q76xcfkWp h8ATvldkRRDOZtgiMBZSkkPYXKITQ33Tq5+NFH9HzDnenztI0NjzLcio01wE+or5OVdi eTNYyK1+X2BEXYTrGq/rG8hgJa6ZhU8O5/Fd+VTsAsdvS7q7jdTZPXj52yD+ag9Ry4N/ UV+g== X-Gm-Message-State: AOAM530SDQ9Cd6IaNjzdpGG4cLwEp1ai/33er1C68eGWaKhw2xRWtSNj v9M7swDF2BtuZlACxiPw+R3r7Q== X-Google-Smtp-Source: ABdhPJzKCUSZJqOzt3dbkryHojrQXKpQJuxr7QZ+UN7WNJaYlvZJZ5a+oZe7pnDBf361bDgAToa+fQ== X-Received: by 2002:adf:c3c8:: with SMTP id d8mr31661848wrg.406.1597217400759; Wed, 12 Aug 2020 00:30:00 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id g145sm2965068wmg.23.2020.08.12.00.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 00:30:00 -0700 (PDT) In-Reply-To: <20200811190422.0409E20CB8@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 11 Aug 2020 15:04:21 -0400 (EDT)") Received-SPF: none client-ip=2a00:1450:4864:20::431; envelope-from=contovob@tcd.ie; helo=mail-wr1-x431.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253668 Archived-At: larsi@gnus.org (Lars Ingebrigtsen) writes: > branch: master > commit 4d00db5538dc0ef47cf1cdf425b895d04145fe9e > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Remove compat code from comint.el > > * lisp/comint.el (make-comint-in-buffer): `start-file-process' is > always defined, so remove test. > --- > lisp/comint.el | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lisp/comint.el b/lisp/comint.el > index df947b9..843cba1 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -735,8 +735,6 @@ contents are sent to the process as its initial input. > If PROGRAM is a string, any more args are arguments to PROGRAM. > > Return the (possibly newly created) process buffer." > - (or (fboundp 'start-file-process) > - (error "Multi-processing is not supported for this system")) > (setq buffer (get-buffer-create (or buffer (concat "*" name "*")))) > ;; If no process, or nuked process, crank up a new one and put buffer in > ;; comint mode. Otherwise, leave buffer and existing process alone. Perhaps the code here and in the previous commit meant to check for (fboundp 'make-process) instead? start-file-process may always be defined, but I don't recall all platforms supporting subprocesses. Or is this check no longer deemed necessary? Thanks, -- Basil