From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 4d00db5 8/8: Remove compat code from comint.el
Date: Wed, 12 Aug 2020 08:29:59 +0100 [thread overview]
Message-ID: <87364sgw3s.fsf@tcd.ie> (raw)
In-Reply-To: <20200811190422.0409E20CB8@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 11 Aug 2020 15:04:21 -0400 (EDT)")
larsi@gnus.org (Lars Ingebrigtsen) writes:
> branch: master
> commit 4d00db5538dc0ef47cf1cdf425b895d04145fe9e
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Remove compat code from comint.el
>
> * lisp/comint.el (make-comint-in-buffer): `start-file-process' is
> always defined, so remove test.
> ---
> lisp/comint.el | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lisp/comint.el b/lisp/comint.el
> index df947b9..843cba1 100644
> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -735,8 +735,6 @@ contents are sent to the process as its initial input.
> If PROGRAM is a string, any more args are arguments to PROGRAM.
>
> Return the (possibly newly created) process buffer."
> - (or (fboundp 'start-file-process)
> - (error "Multi-processing is not supported for this system"))
> (setq buffer (get-buffer-create (or buffer (concat "*" name "*"))))
> ;; If no process, or nuked process, crank up a new one and put buffer in
> ;; comint mode. Otherwise, leave buffer and existing process alone.
Perhaps the code here and in the previous commit meant to check for
(fboundp 'make-process) instead? start-file-process may always be
defined, but I don't recall all platforms supporting subprocesses. Or
is this check no longer deemed necessary?
Thanks,
--
Basil
next parent reply other threads:[~2020-08-12 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200811190418.24261.58579@vcs0.savannah.gnu.org>
[not found] ` <20200811190422.0409E20CB8@vcs0.savannah.gnu.org>
2020-08-12 7:29 ` Basil L. Contovounesios [this message]
2020-08-12 11:03 ` master 4d00db5 8/8: Remove compat code from comint.el Lars Ingebrigtsen
2020-08-12 14:26 ` Eli Zaretskii
2020-08-12 14:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87364sgw3s.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.