From: No Wayman <iarchivedmywholelife@gmail.com>
To: 43467@debbugs.gnu.org
Subject: bug#43467: 28.0.50; [PATCH] defcustom warning-show-suppression-buttons
Date: Thu, 17 Sep 2020 11:52:04 -0400 [thread overview]
Message-ID: <87363g8krw.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
User-agent: mu4e 1.5.5; emacs 28.0.50
User-agent: mu4e 1.5.5; emacs 28.0.50
BCC: No Wayman <iarchivedmywholelife@gmail.com>
The new warning suppression button behavior introduced in
66d01012ba61a364fe92cdc1728bfa135a90626a
is a great idea, but I don't have much use for it and would prefer
to not have the buttons clutter
the *Warnings* buffer.
The attached patch introduces a defcustom to control the display
of the buttons.
Thanks,
Nicholas Vollmer
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: defcustom-warning-show-suppression-buttons --]
[-- Type: text/x-patch, Size: 1560 bytes --]
From 74b2cce64bb0a1c6a65749b055078e5b1c326160 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Thu, 17 Sep 2020 11:40:41 -0400
Subject: [PATCH] Allow customization of warning suppression button display
* lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons):
new defcustom to disable/enable display of warning suppression buttons
in *Warnings* buffer.
---
lisp/emacs-lisp/warnings.el | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index e10c149d89..35e9870d1a 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -116,6 +116,11 @@ warning-suppress-types
See also `warning-suppress-log-types'."
:type '(repeat (repeat symbol))
:version "22.1")
+
+(defcustom warning-show-suppression-buttons t
+ "Whether or not to show suppresion buttons in the *Warnings* buffer.
+If t, buttons are shown, else they are not."
+ :type 'boolean)
\f
;; The autoload cookie is so that programs can bind this variable
;; safely, testing the existing value, before they call one of the
@@ -294,7 +299,7 @@ display-warning
message)
;; Don't output the buttons when doing batch compilation
;; and similar.
- (unless noninteractive
+ (unless (or noninteractive warning-show-suppression-buttons)
(insert " ")
(insert-button "Disable showing"
'type 'warning-suppress-warning
--
2.28.0
[-- Attachment #3: Type: text/plain, Size: 38 bytes --]
Date: Thu, 17 Sep 2020 11:52:04 -0400
next reply other threads:[~2020-09-17 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 15:52 No Wayman [this message]
2020-09-17 16:04 ` bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction No Wayman
2020-09-17 16:13 ` Robert Pluim
2020-09-17 16:24 ` No Wayman
2020-09-17 16:16 ` Lars Ingebrigtsen
2020-09-17 17:09 ` No Wayman
2020-09-17 17:27 ` Lars Ingebrigtsen
2020-09-17 18:08 ` No Wayman
2020-09-18 13:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87363g8krw.fsf@gmail.com \
--to=iarchivedmywholelife@gmail.com \
--cc=43467@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.