From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#2048: Flymake Enhancement Date: Sat, 19 Sep 2020 23:57:24 +0200 Message-ID: <87363dl9a3.fsf@gnus.org> References: <1232903607.19724.17.camel@tadpole> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 2048@debbugs.gnu.org To: Joseph Donaldson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 23:58:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJksP-0007Kq-7o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 23:58:37 +0200 Original-Received: from localhost ([::1]:56736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJksM-0005aM-Ko for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 17:58:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJkrq-0005a9-Qi for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 17:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJkrq-00062F-H6 for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 17:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJkrq-00006w-GE for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 17:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2048 X-GNU-PR-Package: emacs Original-Received: via spool by 2048-submit@debbugs.gnu.org id=B2048.1600552658377 (code B ref 2048); Sat, 19 Sep 2020 21:58:02 +0000 Original-Received: (at 2048) by debbugs.gnu.org; 19 Sep 2020 21:57:38 +0000 Original-Received: from localhost ([127.0.0.1]:48309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJkrS-000061-48 for submit@debbugs.gnu.org; Sat, 19 Sep 2020 17:57:38 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJkrP-00005j-Uw for 2048@debbugs.gnu.org; Sat, 19 Sep 2020 17:57:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jMl8+VFaCeP6OIVA5rvK9m4BSWko6u5vGxIHEcu/zBs=; b=vOAWDJKuK2fxLx4n11h2uAecEd JgEsDH3UOlkIUfUOvjAB7BPRUE9gArs83nCAa6qoNgNTeIUT0f2ayKOMxMVId88JV6dBAr26zVa3Y 1AO2GRZZuIqUICrToMV7GeNlzyanw/s4i+yaTeu7pz9ntmdnvYb13l5PF5t0w5phFAAM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJkrG-0006yR-8M; Sat, 19 Sep 2020 23:57:29 +0200 X-Now-Playing: The Art of Noise's _In Visible Silence_: "Instruments of Darkness" In-Reply-To: <1232903607.19724.17.camel@tadpole> (Joseph Donaldson's message of "Sun, 25 Jan 2009 12:13:27 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188443 Archived-At: Joseph Donaldson writes: > I hope this is the right forum for submitting this patch for flymake. If > it is not, please, direct me to the correct one. While working to get > flymake to work with the bigloo scheme compiler I discovered that when > it examines the compiler output it does so line-by-line.=20 This was 11 years ago, and the bug report unfortunately didn't get a lot of attention at the time. However, I think the underlying problem was fixed by Jo=C3=A3o a few years back, so I'm closing this bug report. If the problem still persists in newer versions of Emacs, please respond to the debbugs address and we'll reopen. commit 6954270e87e3a9f829cd6e8c89febc2c0bc48845 Author: Jo=C3=A3o T=C3=A1vora AuthorDate: Wed Aug 23 02:23:41 2017 +0100 Completely rewrite Flymake's subprocess output processing =20=20=20=20 Instead of parsing and matching regexps line-by-line, insert subprocess output in a separate buffer and parse using `search-forward-regexp'. This eventually enables multi-line error patterns and simplifies code all around. Store per-check information in the subprocess using `process-get' and `process-put'. Treat error messages, warnings, etc. more generically as "diagnostics". Create these objects as soon as possible, reusing existing `flymake-ler' structure. Fix some whitespace. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no