From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 20:12:59 +0100 Message-ID: <87360gaz7o.fsf@gnus.org> References: <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <837dpt8lk5.fsf@gnu.org> <87pn3kjssr.fsf@gnus.org> <83im9c70vu.fsf@gnu.org> <87im9cfeej.fsf@gnus.org> <837dps6xyv.fsf@gnu.org> <87czzkdx57.fsf@gnus.org> <83v9dc5he3.fsf@gnu.org> <87r1o0chk9.fsf@gnus.org> <83tusw5g5o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1573"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: ghe@sdf.org, Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 20:32:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmijI-0000Jd-GC for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 20:32:56 +0100 Original-Received: from localhost ([::1]:55808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmijH-0003wF-Eb for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 14:32:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmiQF-00079U-2G for emacs-devel@gnu.org; Tue, 08 Dec 2020 14:13:15 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:45248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmiQA-0007LE-Gy; Tue, 08 Dec 2020 14:13:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LYy7dn5VMotj8rAmHgycdDBs4VdkhU3Z/d+ixV4/8sE=; b=WZSpfQ4IZGqnFATO+j7NccJgoC IGTFY0dt3Vt3itDeb/bbey3oChRLwb3s0DHb6Bk0REpnTeKV8ynprrZnCFeUyEPacYJf0i3Oaj0kH vlQaRF3ObASPwP60gvl2MS8zjmkr9PzUNHeQyM99MaX4+NPetiSs1/4i2ngo47bT5JZE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmiQ0-0006rH-4s; Tue, 08 Dec 2020 20:13:02 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUCAQQSDAgVExA0 LiQmGxBzZEdjUikzJxS0lkKKcS2hjFZFNh6LdkvPx6n////4bZDmAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+QMCBMDER64WMIAAAE8SURBVDjLY2CAAEZBIFAUZEACzGBxASB2YEABrAFAwjSBgYG9HchQ A6pgsCwAy6wGMYESjClAxq5ABga2NgGwhBsQs4CYCkBcCdRfWQC1F9lgkIpyBQbsgJFh4EHVBpCH QY7ZCOIiwsVnIpDYAeSztYAC6BBCC8jT7KBABGlliwZ6ciY2zxUCVU0baO/hArBksRnD2QwMVncY GLg7gB7kBiUGNgOgB0+DJdStgcw0oBj3dCAhCfQ+ezoiFh1RzHFB2IHT8gGREGJgYAoB0swbMCXA qd92AVTAtAAY7wvAEmDP3QUGCfsBIGNHAAMDDxArQRUmAjETyDh2BUj2UsJl+aCV0EgA0twgDPQX wzYg1lYAS0hOALKlHIB4MZAxE+i5msVgCZA/wXEvth1IlIPMUUG1A6wCYQeOGFECAIj5KsgiIEKG AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEyLTA4VDE5OjAzOjE3KzAwOjAwlvyqhwAAACV0RVh0 ZGF0ZTptb2RpZnkAMjAyMC0xMi0wOFQxOTowMzoxNyswMDowMOehEjsAAAAASUVORK5CYII= X-Now-Playing: clipping.'s _Visions of Bodies Being Burned_: "Chek the Lock" In-Reply-To: (Stefan Monnier's message of "Tue, 08 Dec 2020 13:39:44 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260579 Archived-At: I'm doing some benchmarking here, and my test case is to insert 200 big-ish images in a buffer, and then scrolling through the buffer. :data image, current sxhash, equal_lists: 6.3s. :data image, NOOP sxhash, equal_lists: 3.4s. :file image, current sxhash, equal_lists: 3.4s. :file image, NOOP sxhash, equal_lists: 3.4s. :data image, current sxhash, Fequal: 6.4s. :data image, NOOP sxhash, Fequal: 3.4s. So -- the Fequal/equal_list doesn't make any difference. As suspected, the sxhash is the major opportunity to speed things up in this area. Now, if we want to retain Fequal-ity (which is what Emacs 27 does), we can't make sxhash more efficient here. However, if we continue using equal_lists (which compares list members with EQ), we can write a new hash function for image.c that just uses identity/number values of the elements, and we'd get a nice speed-up. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no