From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Philip K." Newsgroups: gmane.emacs.devel Subject: Re: POLL: make C-x o transient Date: Thu, 28 Jan 2021 08:46:58 +0100 Message-ID: <8735ylpkp9.fsf@posteo.net> References: <2EFBBE54-62F4-4373-82D6-DC8750B648BA@kuaishou.com> <87eei9xb5r.fsf@mail.linkov.net> <87sg6m5mjs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13857"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: "condy0919@gmail.com" , Stefan Monnier , Zhiwei Chen , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 28 08:48:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l522b-0003UY-II for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 08:48:33 +0100 Original-Received: from localhost ([::1]:60854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l522a-00026G-HM for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 02:48:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l521D-0000P2-L8 for emacs-devel@gnu.org; Thu, 28 Jan 2021 02:47:07 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:36247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l521B-0001mZ-Dl for emacs-devel@gnu.org; Thu, 28 Jan 2021 02:47:07 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E5749240105 for ; Thu, 28 Jan 2021 08:47:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1611820020; bh=s4Zo/kGRM0VQQDpIzArozdlAH1zUL/yuMdpCjCmJ4sE=; h=From:To:Cc:Subject:Date:From; b=T/VAepjALtSbWkmVgpYcymKNHwNX1fgd+3uQsgWXwJOqCIODr0cRYSa6TYGlgUztb CNJwrZgPr1ESE2m4+Y4NQjqyfA1Fjki7VDkt6ddq51eQb/fzptyg1SzR/+PD+WiGtJ j9pWnrRVa5B+OyyLAVhs99VxLauMtspbOg/TGBOXXyGlfb4qWe3bwZB8vVlCSKL7xz TAtwZ3H6Mf+ajTOvvSbYaP1ZltokARNFfcuycYonTR1vtPfJx8rE7JkuzKhbBYOaJJ VUVtqMUiZwl/pwzx0da5i+CYhookxwhOSXfUVGJomW+M3XZEAcn/RsdS0wb1BOd2ad 2CpivTAKJGm6w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DRCGq3k3Rz6tmP; Thu, 28 Jan 2021 08:46:59 +0100 (CET) In-Reply-To: <87sg6m5mjs.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 27 Jan 2021 19:55:03 +0200") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263539 Archived-At: Juri Linkov writes: >>>> Which will make `C-x o` invoke a transient version of `other-window' >>>> like `text-scale-adjust=E2=80=99 does. >>> >>> I think the pattern is clear: `C-x ` are good candidates ;-) >> >> And non-letters too, especially `C-x {`, `C-x }`, `C-x ^`, ... >> need to be repeatable. I'm using such quite messy blob of code, >> it would be nice if someone would generalize this mess >> without using advice-add. > > Maybe something simple like: > > #+begin_src emacs-lisp > (put 'other-window 'repeatable-command t) > (put 'enlarge-window 'repeatable-command t) > (put 'enlarge-window-horizontally 'repeatable-command t) > (put 'shrink-window-horizontally 'repeatable-command t) > > (add-hook 'post-command-hook 'repeatable-command) > > (defun repeatable-command () > (when (get this-command 'repeatable-command) > (let* ((keys (this-single-command-keys)) > (last-key (elt keys (1- (length keys))))) > (set-transient-map > (let ((map (make-sparse-keymap))) > (define-key map (vector last-key) this-command) > map))))) > #+end_src I like this idea, but would the hook be added by default? --=20 Philip K.