From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: Concern about new binding. Date: Tue, 02 Feb 2021 11:04:15 -0700 Message-ID: <8735ye5otc.fsf@melete.silentflame.com> References: <20210202134950.vybbpf3iewbymfjo.ref@Ergus> <20210202134950.vybbpf3iewbymfjo@Ergus> <878s86tnv6.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28312"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ergus , emacs-devel@gnu.org To: thibaut.verron@gmail.com, Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 19:25:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l70Mr-0007Fp-DK for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 19:25:37 +0100 Original-Received: from localhost ([::1]:56548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l70Mq-0006Dx-F2 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 13:25:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l701Z-0005OX-1X for emacs-devel@gnu.org; Tue, 02 Feb 2021 13:03:37 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l701T-00059U-BK for emacs-devel@gnu.org; Tue, 02 Feb 2021 13:03:35 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B539C5C006C; Tue, 2 Feb 2021 13:03:28 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 02 Feb 2021 13:03:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=7qp8/DrYoh7smtuH04ZfG0PkZt 7JuCgxuLgYaNDVWN8=; b=r/BFiomfBUTRQF8se05FyzB4nrHNqouNFBgA58QQCF FCcJN9ks1q2uRqcpdBQzB89FbnrDUTZant8RhiV9iJ5hoJXgJ7S+iBHJsib+bp8y WxwkOzta3Blcc4BHeM87VXVnij6B3cV3Rh5jKDWKCkjnr2rLLjRdLhhrZOizez97 g1HAgEb0rb/77OmWXXFT1RhyJk3Y7U4n2ULyt2VqdRQr5/qUWz84JfRbdlUHDKqA +ENupQFVwBcwKamBD3mdCKeYpQ495RIyOijrRaE0s4vn08tZgft2fQrLS8UArDmJ pwLGp44J1kZE7ChtgE75hq5HbIsBDU5fG5nEh1U0lNwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7qp8/D rYoh7smtuH04ZfG0PkZt7JuCgxuLgYaNDVWN8=; b=PNDm6PBkqdnz0U/GxWtQD3 jJY/LgdwAqvBzf4oE6XGlCgtEsS5jD0gMzEwbj1jZ+Et+6pEzgKVLYs5aPjkhGCS PF2Ji2sECQQCn8HrqRMIHJ98QZNnwQ+1zMw0hBdHdLIpUzDK86xIt/m5XuNR1Wmq Ns1Kp2slejM7xrB3g/SrpqaUhdMW2MBrSiqsypoHSUc2jpdI1crrG6kM3j7NL8W6 6QFs7sdJMW7n1ovlfx4Iv++io7FqAmsXeQ7TGPtnzxbULqH8EeF6wsRF0qyKB9FI fqlVicRCfPrUVTxZ4ix+3k+Nb+4bzS4ggedKK9c6SxwKE1XUYQGg2yC7Z5ArC5cA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgedtgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegteffgfdtueevudevkeetjeduudegvedvveehgeeghfegieef fefhtdffvedvjeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhi thhtohhnrdhnrghmvg X-ME-Proxy: In-Reply-To: Received-SPF: pass client-ip=66.111.4.28; envelope-from=spwhitton@spwhitton.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263734 Archived-At: Hello, On Tue 02 Feb 2021 at 06:45PM +01, Thibaut Verron wrote: > To be clear, Magit itself does not bind anything by default. It > suggests "C-x g" as a binding, and I see now that it also offers an > option to enable that binding for the user. Actually, it's on by default in current git master and in the version of magit in Debian. > It is not the only high-level package using "C-x letter" as an entry > point, another example coming to mind is projectile ("C-x p"). No, projectile was C-c p, but it eventually removed it and just suggested in its docs that users bind it themselves. I think that approach would be sensible for magit too. > As for the conventions, as far as I can tell, they explicitly require > to steer clear of "C-c letter", but they don't have anything about > "C-x letter": > https://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html AFAICT, there's an implicit additional convention that major and minor modes stick to the sequences that are reserved for them. Given this, ISTM that as magit chose to bind C-x g, there was inevitably going to be a clash like this sooner or later. -- Sean Whitton