From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46609: Fix shell password prompt in minibuffer (bug 43302) Date: Thu, 18 Feb 2021 12:44:32 +0100 Message-ID: <8735xty50f.fsf@gnus.org> References: <87czwytbxq.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6548"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46609@debbugs.gnu.org To: Ryan Prior Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 12:45:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lChk7-0001XI-PE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 12:45:11 +0100 Original-Received: from localhost ([::1]:52508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lChk6-0002tF-Pw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 06:45:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lChjy-0002s9-G0 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 06:45:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lChjy-0001lA-72 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 06:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lChjy-000669-46 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 06:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46609 X-GNU-PR-Package: emacs Original-Received: via spool by 46609-submit@debbugs.gnu.org id=B46609.161364868423405 (code B ref 46609); Thu, 18 Feb 2021 11:45:02 +0000 Original-Received: (at 46609) by debbugs.gnu.org; 18 Feb 2021 11:44:44 +0000 Original-Received: from localhost ([127.0.0.1]:46236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lChjg-00065R-0c for submit@debbugs.gnu.org; Thu, 18 Feb 2021 06:44:44 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:46842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lChje-00065F-BG for 46609@debbugs.gnu.org; Thu, 18 Feb 2021 06:44:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GLo3kyvBAIliino6nDqL6w+WIC2Q9nxL6HHex2TOo7A=; b=vUVIrLCDoVdFDZYkrm2bG8LjG8 jJuFWe9SnzVirWvxes2QQZXaXFmDpaNGGTBPPyhBymSxaJbnI/nj/ipc/NxuLRpK2rWmvNjwzK635 0sbc66BWgsfRvGNcqqCr43rE4ZfSYMiqSSBV+HduNhR73ezH983OEVazLQ2Z9xzJmkLU=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lChjW-0005H8-1d; Thu, 18 Feb 2021 12:44:36 +0100 X-Now-Playing: Leafcutter John's _Firecamp Stories Remixes_: "The Ballad of Jimmy Hollin is MOre Awkward Than That" In-Reply-To: <87czwytbxq.fsf@protonmail.com> (Ryan Prior's message of "Thu, 18 Feb 2021 01:13:58 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200243 Archived-At: Ryan Prior writes: > The current comint-password-prompt-regexp does not tolerate newlines at > the end of the prompt, so a string like "Password:\n" will not be > recognized as a password prompt in shell-mode. Before Emacs 27 > (74277b0e881) newlines were tolerated here, so this is a regression, and > as a result I would sometimes echo my password in plain text where > previously it would be hidden. Thanks; applied to Emacs 27 with one change: > + (when (string-match "[\n]+$" string) > + (setq string (replace-match "" t t string))) This should probably be "\n+\\'", because we only want to remove newlines from the end of the string, and not newlines from the middle of the string, presumably? ("$" means "match end of line", not "match end of string".) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no