From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, stefan@marxist.se, 24774@debbugs.gnu.org
Subject: bug#24774: 26.0.50; Menu display navigation commands
Date: Sat, 27 Feb 2021 05:30:39 +0100 [thread overview]
Message-ID: <8735xiku8g.fsf@gnus.org> (raw)
In-Reply-To: <838s7bqai9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Feb 2021 14:27:58 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Because it's a better, more sensible way to define menus.
>
> But the same argument can be brought up for cl-macs.el and cl-lib.el
> and seq.el and map.el and pcase.el and probably several others.
Yes, of course.
> Where do we stop, if the criterion is "better and more sensible"
> (which are highly subjective judgments)?
I don't think anybody claims that the non-easymenu way of defining menus
is superior?
Our most important code is the one that is in the very core of Emacs,
and it's a shame we don't use more of these libraries there, and instead
open-code stuff badly.
easymenu.el is over-ripe for preloading since it's very hard to do much
in Emacs without it being pulled in anyway -- so you get no space
savings in practice, but just a slower Emacs.
>> (And possibly smaller .elc file, as I said.)
>
> I'd like to see the actual numbers, please. And also the memory
> footprint before and after loading easymenu. With the current code, I
> see a 0.25MB increase in the VM size after I load easymenu.elc.
Pre patch:
larsi@xo:~/src/emacs/trunk$ ls -l src/emacs src/emacs.pdmp lisp/progmodes/elisp-mode.elc
-rw-r--r-- 1 larsi larsi 60375 Feb 27 05:09 lisp/progmodes/elisp-mode.elc
-rwxr-xr-x 2 larsi larsi 32583784 Feb 27 05:10 src/emacs
-rw-r--r-- 2 larsi larsi 10630544 Feb 27 05:10 src/emacs.pdmp
Post patch:
larsi@xo:~/src/emacs/trunk$ ls -l src/emacs src/emacs.pdmp lisp/progmodes/elisp-mode.elc
-rw-r--r-- 1 larsi larsi 58798 Feb 27 05:21 lisp/progmodes/elisp-mode.elc
-rwxr-xr-x 2 larsi larsi 32583784 Feb 27 05:21 src/emacs
-rw-r--r-- 2 larsi larsi 10632360 Feb 27 05:21 src/emacs.pdmp
(- (+ 10632360 58798) (+ 10630544 60375)) => 239 bytes.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-02-27 4:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 16:28 bug#24774: 26.0.50; Menu display navigation commands Andreas Röhler
2019-07-27 13:18 ` Lars Ingebrigtsen
2019-07-30 7:54 ` Andreas Röhler
2019-07-30 10:25 ` Lars Ingebrigtsen
2020-11-18 15:34 ` Stefan Kangas
2020-11-18 21:09 ` Lars Ingebrigtsen
2020-11-18 22:01 ` Drew Adams
2020-11-18 22:16 ` Stefan Kangas
2020-11-18 23:16 ` Drew Adams
2020-11-19 1:10 ` Stefan Kangas
2021-02-23 15:19 ` Stefan Kangas
2021-02-23 15:29 ` Lars Ingebrigtsen
2021-02-23 15:57 ` Eli Zaretskii
2021-02-23 16:02 ` Lars Ingebrigtsen
2021-02-23 16:14 ` Lars Ingebrigtsen
2021-02-23 16:16 ` Eli Zaretskii
2021-02-23 16:37 ` Stefan Kangas
2021-02-23 16:44 ` Eli Zaretskii
2021-02-25 1:25 ` Stefan Kangas
2021-02-25 9:04 ` Stephen Berman
2021-02-25 9:24 ` Eli Zaretskii
2021-02-25 15:09 ` Lars Ingebrigtsen
2021-02-25 15:27 ` Eli Zaretskii
2021-02-25 15:52 ` Lars Ingebrigtsen
2021-02-25 18:18 ` Eli Zaretskii
2021-02-25 19:20 ` Eli Zaretskii
2021-02-26 8:48 ` Lars Ingebrigtsen
2021-02-26 12:04 ` Eli Zaretskii
2021-02-26 12:07 ` Lars Ingebrigtsen
2021-02-26 12:27 ` Eli Zaretskii
2021-02-27 4:30 ` Lars Ingebrigtsen [this message]
2021-02-27 5:27 ` Lars Ingebrigtsen
2021-02-27 6:14 ` bug#24774: [External] : " Drew Adams
2021-02-27 7:43 ` Eli Zaretskii
2021-02-27 11:50 ` Lars Ingebrigtsen
2021-02-27 12:56 ` Eli Zaretskii
2021-02-27 13:25 ` Lars Ingebrigtsen
2021-02-27 13:32 ` Eli Zaretskii
2021-02-27 13:49 ` Lars Ingebrigtsen
2021-02-27 13:58 ` Eli Zaretskii
2021-02-27 14:24 ` Lars Ingebrigtsen
2021-02-26 16:04 ` bug#24774: [External] : " Drew Adams
2021-02-23 16:50 ` Basil L. Contovounesios
2021-02-23 17:10 ` Eli Zaretskii
2021-02-23 17:24 ` Gregory Heytings
2021-02-23 17:37 ` Eli Zaretskii
2021-02-24 15:12 ` Lars Ingebrigtsen
2021-02-24 16:01 ` Stephen Berman
2021-02-24 16:06 ` Lars Ingebrigtsen
2021-02-27 14:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735xiku8g.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24774@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stefan@marxist.se \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.