From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Tue, 02 Mar 2021 10:35:02 +0000 Message-ID: <8735xdx2qx.fsf@tcd.ie> References: <87im9fgm27.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <83eegy6r30.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20764"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Protesilaos Stavrou , maurooaranda@gmail.com, 45068@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 11:36:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH2OC-0005Fr-N3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 11:36:28 +0100 Original-Received: from localhost ([::1]:46986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH2OB-0005cL-Pg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 05:36:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH2Nr-0005YZ-Na for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 05:36:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lH2Nm-0004x8-KJ for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 05:36:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lH2Nm-00025U-6y for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 05:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16146813117943 (code B ref 45068); Tue, 02 Mar 2021 10:36:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 2 Mar 2021 10:35:11 +0000 Original-Received: from localhost ([127.0.0.1]:51912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH2Mw-000243-NH for submit@debbugs.gnu.org; Tue, 02 Mar 2021 05:35:10 -0500 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:44146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH2Mv-00023i-Gd for 45068@debbugs.gnu.org; Tue, 02 Mar 2021 05:35:10 -0500 Original-Received: by mail-wr1-f49.google.com with SMTP id h98so19267588wrh.11 for <45068@debbugs.gnu.org>; Tue, 02 Mar 2021 02:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ncUSArVRpe3IPkn4Sy1XfEJhuhMWOqsnlfHpCeRt294=; b=c9CEHK4XUTYVblJWlhpi2tjNpfqAK8Iu52dfKge1qHrFq0d6fSfH8oYPzfcLMu6l6f lgtXF3tThfrX8Oc/gmXbEq776xhAAdwpeLlAorXmzuCOX3sFgzTMizvcwWugwAmtOIUQ VnF4Ybue9fwCm5rdLx66Y1Fp4CIMKv9pmBbpFxA66D5q+Sq5DA6lLi0dv96YdYtQm5tP GvcL+XuneZh3EcSbumY3Ekd7Db94WdYHB7wDef1FXR1TYVMS/mnahiSue/fpCKrroQDi 7SuCE15ZwDtMd4DWEG2fUpjan2pTbMDdZFVqukx7EFn3Dzf8n1AISTWQPuDIFSR2GT1m SAzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ncUSArVRpe3IPkn4Sy1XfEJhuhMWOqsnlfHpCeRt294=; b=PtqjzD+pzB0S9AhqpFXBJSvVMqzY5a/O8a2cDBLO+k5G544Kgvg3UAIFVn4Em/0lt3 mUQTbKytFdYhLsU8rutnNyXt1VYJE79u7Li+J0QQq4v8kFG5fIljdZrVmybDEeGi1QjK JKAy9bl64l9J+tldqyEPix5FmqR5B5JkPSJ4xUsSuzV0AcVSE75e3++JP1ArRxGhNJR5 9UvqbsXlTLhMADSop8porJmMuvFv8nF33rC+bUvp7q7uKWtN4/4EbViBVeR9MB8kknDi kb2oz/047bklDrRqnvRI4k5uB1Oj4OjZhSB+TJIjGIkY3WK8aQDnKCiyxdKwNqgY8RwC CM6w== X-Gm-Message-State: AOAM5304RBy6q5u+gE2XUGEmLKDUVXiew7AD0vZ/yFMCve0MNAlEPPd0 O/ZJl0WEH7CbWBe/yAYXUcvTFw== X-Google-Smtp-Source: ABdhPJyfC7TXun/U+VFPDpkcJDE6RbW4Fs+iil9KMiQgLIo/YAQQW8XZLb3Qrm5Pp12IVP+Nql743Q== X-Received: by 2002:adf:ecca:: with SMTP id s10mr13327927wro.324.1614681303844; Tue, 02 Mar 2021 02:35:03 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id j125sm2088973wmb.44.2021.03.02.02.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 02:35:03 -0800 (PST) In-Reply-To: <83eegy6r30.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Mar 2021 07:51:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201204 Archived-At: Eli Zaretskii writes: >> From: Protesilaos Stavrou >> Cc: Mauro Aranda , Eli Zaretskii , >> 45068@debbugs.gnu.org >> Date: Tue, 02 Mar 2021 07:47:58 +0200 >> >> > (defun require-theme (feature &optional noerror) >> > (let ((load-path (custom-theme--load-path))) >> > (require feature nil noerror))) >> >> No the themes do not need that dual behaviour. And yes, your version >> works and I am happy with it: all I need is a 'require' that reads from >> etc/themes. > > Won't the above version cause problems if the loaded theme needs to > require some Emacs package? Binding load-path would get in the way of > that, no? Probably, so locate-file is indeed the way to go. (The above was mostly an illustration.) Thanks, -- Basil