From: Utkarsh Singh <utkarsh190601@gmail.com> To: 47820@debbugs.gnu.org, emacs-orgmode@gnu.org Subject: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match Date: Fri, 16 Apr 2021 14:31:42 +0530 [thread overview] Message-ID: <8735vqzjpl.fsf@gmail.com> (raw) Hi, Can we give small flexibility in choosing the filename interactively for `org-table-import'? Currently org-table-import will just throw an error when file name doesn't have .txt, .csv or .tsv as extension. This patch tries to add a simple yes-and-no to let user choose if they want to continue importing or not. diff --git a/lisp/org/org-table.el b/lisp/org/org-table.el index 0e93fb271f..ab66859d6a 100644 --- a/lisp/org/org-table.el +++ b/lisp/org/org-table.el @@ -938,7 +938,8 @@ org-table-import - regexp When a regular expression, use it to match the separator." (interactive "f\nP") (when (and (called-interactively-p 'any) - (not (string-match-p (rx "." (or "txt" "tsv" "csv") eos) file))) + (not (string-match-p (rx "." (or "txt" "tsv" "csv") eos) file)) + (not (yes-or-no-p "File doesn't have .txt, .tsv or .csv as extension. Do you still want to continue? "))) (user-error "Cannot import such file")) (unless (bolp) (insert "\n")) (let ((beg (point)) -- Utkarsh Singh http://utkarshsingh.xyz
WARNING: multiple messages have this Message-ID (diff)
From: Utkarsh Singh <utkarsh190601@gmail.com> To: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Subject: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match Date: Fri, 16 Apr 2021 14:31:42 +0530 [thread overview] Message-ID: <8735vqzjpl.fsf@gmail.com> (raw) Hi, Can we give small flexibility in choosing the filename interactively for `org-table-import'? Currently org-table-import will just throw an error when file name doesn't have .txt, .csv or .tsv as extension. This patch tries to add a simple yes-and-no to let user choose if they want to continue importing or not. diff --git a/lisp/org/org-table.el b/lisp/org/org-table.el index 0e93fb271f..ab66859d6a 100644 --- a/lisp/org/org-table.el +++ b/lisp/org/org-table.el @@ -938,7 +938,8 @@ org-table-import - regexp When a regular expression, use it to match the separator." (interactive "f\nP") (when (and (called-interactively-p 'any) - (not (string-match-p (rx "." (or "txt" "tsv" "csv") eos) file))) + (not (string-match-p (rx "." (or "txt" "tsv" "csv") eos) file)) + (not (yes-or-no-p "File doesn't have .txt, .tsv or .csv as extension. Do you still want to continue? "))) (user-error "Cannot import such file")) (unless (bolp) (insert "\n")) (let ((beg (point)) -- Utkarsh Singh http://utkarshsingh.xyz
next reply other threads:[~2021-04-16 9:01 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-16 9:01 Utkarsh Singh [this message] 2021-04-16 9:01 ` [PATCH] org-table-import: Give option to import interactively even if filename doesn't match Utkarsh Singh 2021-05-01 8:51 ` bug#47820: " Bastien 2021-05-01 8:51 ` Bastien 2021-05-01 15:14 ` Utkarsh Singh 2021-05-01 15:14 ` Utkarsh Singh 2021-05-01 16:06 ` Bastien 2021-05-01 16:50 ` Utkarsh Singh 2021-05-01 16:50 ` Utkarsh Singh 2021-05-01 16:06 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8735vqzjpl.fsf@gmail.com \ --to=utkarsh190601@gmail.com \ --cc=47820@debbugs.gnu.org \ --cc=emacs-orgmode@gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.