From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 49782-done@debbugs.gnu.org
Subject: bug#49782: 28.0.50; set-fontset-font crashes in init (server)
Date: Sat, 31 Jul 2021 15:05:44 +0200 [thread overview]
Message-ID: <8735ru3a6v.fsf@turtle-trading.net> (raw)
In-Reply-To: <83wnp7po2q.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Jul 2021 23:02:37 +0300")
Hi Eli,
Eli Zaretskii writes:
> (I cannot produce such a backtrace myself, because your recipe
> involves 3 different processes, one of which forks, which is hard to
> follow with GDB on a system I have here.)
Same problem here. I tried 'emacsclient -a "gdbserver emacs"', but than
the problem does not reproduce. Or maybe I was doing something wrong.
Eli Zaretskii writes:
> But before you embark on that adventure, please try another stab in
> the dark:
>
> diff --git a/src/fontset.c b/src/fontset.c
> index d2d428d..7d4bd65 100644
> --- a/src/fontset.c
> +++ b/src/fontset.c
> @@ -1356,15 +1356,16 @@ check_fontset_name (Lisp_Object name, Lisp_Object *frame)
> int id;
> struct frame *f = decode_live_frame (*frame);
>
> - if (!FRAME_WINDOW_P (f) && !FRAME_INITIAL_P (f))
> - error ("Can't use fontsets in non-GUI frames");
> -
> XSETFRAME (*frame, f);
>
> if (EQ (name, Qt))
> return Vdefault_fontset;
> if (NILP (name))
> - id = FRAME_FONTSET (f);
> + {
> + if (!FRAME_WINDOW_P (f))
> + error ("Can't use fontsets in non-GUI frames");
> + id = FRAME_FONTSET (f);
> + }
> else
> {
> CHECK_STRING (name);
Yes, this works. It works for running Emacs directly as well as through
'emacsclient -a ""' and 'emacsclient -a "emacs"'. I think this is it.
Thank you,
benny
next prev parent reply other threads:[~2021-07-31 13:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 12:54 bug#49782: 28.0.50; set-fontset-font crashes in init (server) Benjamin Riefenstahl
2021-07-30 14:05 ` Benjamin Riefenstahl
2021-07-30 14:10 ` Eli Zaretskii
2021-07-30 17:50 ` Benjamin Riefenstahl
2021-07-30 18:19 ` Eli Zaretskii
2021-07-30 18:35 ` Benjamin Riefenstahl
2021-07-30 18:52 ` Eli Zaretskii
2021-07-30 19:26 ` Benjamin Riefenstahl
2021-07-30 20:02 ` Eli Zaretskii
2021-07-30 20:12 ` Eli Zaretskii
2021-07-31 6:29 ` Eli Zaretskii
2021-07-31 13:05 ` Benjamin Riefenstahl [this message]
2021-07-31 13:23 ` Eli Zaretskii
2021-07-30 20:07 ` Lars Ingebrigtsen
2021-07-30 20:09 ` Lars Ingebrigtsen
2021-07-31 12:57 ` Benjamin Riefenstahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ru3a6v.fsf@turtle-trading.net \
--to=b.riefenstahl@turtle-trading.net \
--cc=49782-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.