From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Fri, 06 Aug 2021 03:41:17 +0300 Organization: LINKOV.NET Message-ID: <8735rn8jz6.fsf@mail.linkov.net> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> <877dh18lj3.fsf@mail.linkov.net> <83y29gjvjh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29906"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 06 03:07:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBoKZ-0007at-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 03:07:23 +0200 Original-Received: from localhost ([::1]:45966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBoKX-00080V-1K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Aug 2021 21:07:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBoKF-00080M-It for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 21:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBoKE-0003eI-UA for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 21:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBoKE-00050C-Hd for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 21:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2021 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.162821198519181 (code B ref 41343); Fri, 06 Aug 2021 01:07:02 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 6 Aug 2021 01:06:25 +0000 Original-Received: from localhost ([127.0.0.1]:48718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBoJd-0004zJ-KE for submit@debbugs.gnu.org; Thu, 05 Aug 2021 21:06:25 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:33465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBoJb-0004z5-Gc for 41343@debbugs.gnu.org; Thu, 05 Aug 2021 21:06:23 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id BCAFB1BF205; Fri, 6 Aug 2021 01:06:16 +0000 (UTC) In-Reply-To: <83y29gjvjh.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Aug 2021 08:43:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211285 Archived-At: >> > Do we really have to hard-code the mouse button this way, including >> > explicit values in C? Why is that necessary or justified? >> >> In tab-line.el it was very easy to bind mouse-2 to close the tab: >> >> (defvar tab-line-tab-map >> (let ((map (make-sparse-keymap))) >> (define-key map [tab-line mouse-1] 'tab-line-select-tab) >> (define-key map [tab-line mouse-2] 'tab-line-close-tab) >> >> But it's impossible to do the same for the menu-bar and the tool-bar >> and so in the tab-bar too. > > Why not? What prevents that? It's too late to change how keys are implemented for tab-bar. The tab-bar keymap contains such keys as 'tab-1' and 'C-tab-2', and clicking mouse-1 on tabs emits such events. It doesn't emit 'mouse-1' and 'mouse-2'. >> Or do you mean adding an integer variable that holds >> a number of the mouse button used to close the tab? >> For example, tab-bar-close-tab-mouse-button = 2. > > I think we should explore such possibilities only after we understand > why normal key bindings don't work. It should be possible to implement normal key bindings mouse-1/mouse-2, but such change will not be backward-compatible.