From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#50437: 28.0.50; describe-variable completion loads nndiary; changes variable value Date: Mon, 06 Sep 2021 12:13:32 -0700 Message-ID: <8735qhikkj.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 50437@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 06 21:14:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNK4M-00030W-IN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 21:14:14 +0200 Original-Received: from localhost ([::1]:41266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNK4L-0007YE-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 15:14:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNK4A-0007Wj-2C for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 15:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNK49-0006dS-Qv for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 15:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNK49-0004Hu-N3 for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 15:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Sep 2021 19:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50437 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163095562616452 (code B ref -1); Mon, 06 Sep 2021 19:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Sep 2021 19:13:46 +0000 Original-Received: from localhost ([127.0.0.1]:54456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNK3t-0004HI-Qa for submit@debbugs.gnu.org; Mon, 06 Sep 2021 15:13:46 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNK3s-0004HB-7G for submit@debbugs.gnu.org; Mon, 06 Sep 2021 15:13:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNK3s-0007BD-1n for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 15:13:44 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:55812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNK3p-0006Mu-VH for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 15:13:43 -0400 Original-Received: from localhost (24-113-148-110.wavecable.com [24.113.148.110]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 233D2FA014 for ; Mon, 6 Sep 2021 19:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1630955614; bh=WRQxIsKwsT/T3YjhTxi+mOiolHmVQVzxiChrnqjw/Nk=; h=From:To:Subject:Date:From; b=PMcQIBp+NE8WvRhV+ErUPIYangnNHwzQ46RfgUhGOm3aGzuVLq7vICg556xrEc7Mp 8cUtEYg3gO806LJ81yx3SwTcutmo9BvqH8djMsfHa41xvFjSbyaL6dPpGQKTEjdgl6 XRUEOavpPKyiX6pkC+Ay9tJxdxWcgAIwYqnvH5tw= Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213627 Archived-At: Running describe-variable on Gnus-related variables and then TAB completing in the minibuffer runs `help--symbol-completion-table', which loads all gnus libraries, including 'gnus-diary, which in turn requires 'nndiary, which alters the values of `gnus-extra-headers' and `nnmail-extra-headers'. Leading to the weird reported behavior that inspecting the value of `gnus-extra-headers' can alter the value of `gnus-extra-headers'. nndiary.el probably shouldn't alter variable values at load time; the diff below is one possible solution. 1 file changed, 5 insertions(+), 6 deletions(-) lisp/gnus/nndiary.el | 11 +++++------ modified lisp/gnus/nndiary.el @@ -416,6 +416,11 @@ nndiary-retrieve-headers (deffoo nndiary-open-server (server &optional defs) (nnoo-change-server 'nndiary server defs) + (dolist (header nndiary-headers) + (setq header (intern (format "X-Diary-%s" (car header)))) + ;; Required for building NOV databases and some other stuff. + (add-to-list 'gnus-extra-headers header) + (add-to-list 'nnmail-extra-headers header)) (when (not (file-exists-p nndiary-directory)) (ignore-errors (make-directory nndiary-directory t))) (cond @@ -1557,12 +1562,6 @@ nndiary-renew-article-p ;; The end... =============================================================== -(dolist (header nndiary-headers) - (setq header (intern (format "X-Diary-%s" (car header)))) - ;; Required for building NOV databases and some other stuff. - (add-to-list 'gnus-extra-headers header) - (add-to-list 'nnmail-extra-headers header)) - (unless (assoc "nndiary" gnus-valid-select-methods) (gnus-declare-backend "nndiary" 'post-mail 'respool 'address))