all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: "Daniel Martín" <mardani29@yahoo.es>
Subject: Re: master 48af19c: Fix buffer overflow in ns_compute_glyph_string_overhangs
Date: Fri, 05 Nov 2021 19:37:04 +0100	[thread overview]
Message-ID: <8735oae9f3.fsf@gmx.de> (raw)
In-Reply-To: 20211105023924.2CEBA209C7@vcs0.savannah.gnu.org

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 48af19c1f06c2f3b20e4056bedf137a5e3c0e05e
> Author: Daniel Martín <mardani29@yahoo.es>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Fix buffer overflow in ns_compute_glyph_string_overhangs
>
>     * src/nsterm.m (ns_compute_glyph_string_overhangs): When the first
>     glyph of a glyph string is a composite glyph, `s->nchars' is 0, so
>     "s->char2b + s->nchars - 1" dereferenced a position before buffer
>     `s->char2b'.  Instead, rewrite part of the function to distinguish
>     between character glyphs and composite glyphs.  For character glyphs,
>     calculate the font metrics using the `text_extents' function, passing
>     it the entire glyph string; for composite glyphs, call
>     `composition_gstring_width'. (Bug#51105)
> ---
>  src/nsterm.m | 29 ++++++++++++++++++-----------
>  1 file changed, 18 insertions(+), 11 deletions(-)

This breaks the compilation on emba, see for example
<https://emba.gnu.org/emacs/emacs/-/jobs/31765/raw>.

Best regards, Michael.



       reply	other threads:[~2021-11-05 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211105023922.4023.62369@vcs0.savannah.gnu.org>
     [not found] ` <20211105023924.2CEBA209C7@vcs0.savannah.gnu.org>
2021-11-05 18:37   ` Michael Albinus [this message]
2021-11-05 20:11     ` master 48af19c: Fix buffer overflow in ns_compute_glyph_string_overhangs Daniel Martín
2021-11-05 22:24       ` Lars Ingebrigtsen
2021-11-06 10:43         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735oae9f3.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.