From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size Date: Tue, 21 Dec 2021 09:34:37 +0800 Message-ID: <8735mmzqoi.fsf@yahoo.com> References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33929"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 52676@debbugs.gnu.org, 52676-done@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 21 02:35:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzU3v-0008dJ-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Dec 2021 02:35:31 +0100 Original-Received: from localhost ([::1]:36710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzU3t-0008Pr-A3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Dec 2021 20:35:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzU3S-0008PW-Te for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2021 20:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzU3S-0006cA-4P for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2021 20:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzU3S-00055N-2L for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2021 20:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Dec 2021 01:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52676-done@debbugs.gnu.org id=D52676.164005049319524 (code D ref 52676); Tue, 21 Dec 2021 01:35:02 +0000 Original-Received: (at 52676-done) by debbugs.gnu.org; 21 Dec 2021 01:34:53 +0000 Original-Received: from localhost ([127.0.0.1]:51850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzU3J-00054l-7X for submit@debbugs.gnu.org; Mon, 20 Dec 2021 20:34:53 -0500 Original-Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:46360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzU3G-00054N-Vp for 52676-done@debbugs.gnu.org; Mon, 20 Dec 2021 20:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640050485; bh=WCBEy/PuaLwMKZH7v9WYRY+SWNYF/yINrzjJRb+fsg8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=txGVKLpMCqNvxJ8Hj6+vv8al92vFAf0WbO6wF1R6SJ9Wep3Rd0nzdMenfbsjp3yrGyBVtK8ybrWY7MeZPpVvXdRH5Fjpltdvyg+Ppds70Y7P6jh1J0lfNxOosR6kDZi9z12rmu8BpQgKnupaYIppOTki6dBBYnxILfCWOxnOqOOZTZIpquWh5BNcfKDZrfOqKFVn9PDBv8UTqCyCRQLbOvprqnRHmbcNfe8SY5EftGlQTx6xpSqeDdT6HyGIpEhdiWqSvs5ZbkhiYMPbj3k8hBwmAjQeTeI/sQjz8SjvIRdkOszNa2VxK2NcqOOstzAPCTUzxb7ghUegFmxsnvV5cg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640050485; bh=u6AYhtQvnGVYhStxXPEIY+nB9UIN2tO5zljxpY2ceuA=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ImSqWk9H9akaFlFOcTLXMdFKfbAkGnKo85rXlZAPuH2Q8F0BOWLUpKEOPerhCDf/SBilblRlQBNkZqn0pBUQrYpv25/ArPKM1GSjvxxZU01TqDr1i+mv+oiK3pBW+6YWBToLw3Zjozi9CokUHmDP//VJNnVpNrroethuw45qtAnL+wdw0mPDLc3zIG0814Xb6uEHkbckO1fh+9MkBowTvXAbGTbfNDsw3yykWjh07XmLvOwgMh51hWRP+EL8yQd+xPstE0ukfzxFiYrQconsZLA3nLqWyXqbpZvT1egNkcUJKEa6udsvRtdqIOFI183IDP/t69pgT5Ixtu8arTYf9Q== X-YMail-OSG: 2fvgEDsVM1kf37Ny1RMGhGwlqNevc8uNDa29QXanXKMdSNXbhbRGSvpYpF1A85G zopoUX8qCNBp5tps.uNlZAzG.SwnFMy_9hnXtgW56kkDrVT9dGORAi3WH.ZWhWL4zL2NgTNEq1UW PVE0TGBEpqvDy7vG7yCp0BG2IFtTc7QXMhE5StUtVaF0b0Fmft_uRqdd_aRqMuck0fWl_8Rc9Taf nvsxIyzAGJMsfmCcx2FQE5bat32yPNkckTciAw_8n_nvucidysiIkjLASiDcU_2huPpqUegRGMRA 9Q2wcXk4mrFk2uwc88F5.64lm5HZbK_fjsabgYCJG_zC8TSnSuQVmRfKgSZTdl4cpTqwTPRK_I3g dSQ1dvlmHSjlehiOMGMNDLejGScXWFTl1iBui2KMEJl5bqauYu__oMDDeoD63MDtmI9Sujd_6caK uV7Q0xjvbubctcOg8wN1myypSn9J_n2QJKRnIWEVSBIodexmg.9r3tubyRv0pwf5pIbnWddMYsRE nUs7C49KI_J9ah3r3Mb8deYFmzBPw.j2tHJAPp3hZ4zOp8SFoLwJ2fzsOyyiNdOIq4Sw3URmuY3y XowmpI5SXSFnVB.vX91ulsdufWnVMxn09qCdfs.mhiOjjjmsYrOuiV.0JmKbU3wY66I36YfAG6RL UFRHN0VjiZWzI6xomc7QanLPISBM0xTjME11FwFg5bWT2J6E.JU01PlLMdsnuXxQc1pf7LVeYJOG 7QGYv1sgIL7wljq3bYxfK0m3Nj2FKjy.aJHVWpWDRuVcc.hvqEwjbAdrzBfWwIypWifayqIaRHCS ajx6.OhG_6o_9MSuys.OwQFf3rXv6fd46halski4TT X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 21 Dec 2021 01:34:45 +0000 Original-Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ea741d55c687bd5ca95ffb7e6a0a3132; Tue, 21 Dec 2021 01:34:42 +0000 (UTC) In-Reply-To: <87o85byhqg.fsf@dick> (dick's message of "Mon, 20 Dec 2021 00:20:55 -0500") X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222827 Archived-At: dick writes: > I am sure there was a way to do what you wanted without resorting to > what you did. Perhaps I've been too harsh on you. You've gotten a lot > of poor (but earnest) counsel from emacs-devel. None of the counsel was "poor". If you have anything real to add to the discussion, please quit the rhetoric and say what the problem is out loud. > (cons (car dims*) > (- (cdr dims*) > (save-excursion > (goto-char to) > (if (> (line-end-position) (line-beginning-position)) > (line-pixel-height) > 0)))))))) There goes the part of the performance problem that change was supposed to solve: if you take a look at `pixel-point-and-height-at-unseen-line' in its current slow state, that is similar to what is already being done there. (And once again, your test simply does not work when there is a line-prefix, unlike `pixel-point-and-height-at-unseen-line'.) So before you come to the conclusion that it is ok to remove a change, please take a minute to at least try to understand the logic behind that change.