From: Matthias Meulien <orontee@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master b299c04201: Fix computation of outline heading level for non-git diff
Date: Thu, 17 Feb 2022 08:21:21 +0100 [thread overview]
Message-ID: <8735kim00e.fsf@gmail.com> (raw)
In-Reply-To: <jwv4k4y4m0f.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 16 Feb 2022 15:50:05 -0500")
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (diff--font-lock-prettify): Disable prettify in non-git diff.
>
> Hmmm... why?
Because my experience is that `diff--font-lock-prettify' is broken with
diff not coming from Git. Eg,
[-- Attachment #2: with_prettify.png --]
[-- Type: image/png, Size: 66323 bytes --]
[-- Attachment #3: Type: text/plain, Size: 25 bytes --]
for the attached diff.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: woman.patch --]
[-- Type: text/x-diff, Size: 560 bytes --]
--- woman.el.orig
+++ woman.el
@@ -2299,9 +2299,9 @@
(replace-match woman-unpadded-space-string t t))
;; Discard optional hyphen \%; concealed newlines \<newline>;
- ;; point-size change function \sN,\s+N, \s-N:
+ ;; kerning \/, \,; point-size change function \sN,\s+N, \s-N:
(goto-char from)
- (while (re-search-forward "\\\\\\([%\n]\\|s[-+]?[0-9]+\\)" nil t)
+ (while (re-search-forward "\\\\\\([%\n/,]\\|s[-+]?[0-9]+\\)" nil t)
(woman-delete-match 0))
;; BEWARE: THIS SHOULD PROBABLY ALL BE DONE MUCH LATER!!!!!
[-- Attachment #5: Type: text/plain, Size: 67 bytes --]
I must admit I've not tried to fix it for that diff.
--
Matthias
next prev parent reply other threads:[~2022-02-17 7:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164503923630.1044.8899541087881650110@vcs2.savannah.gnu.org>
[not found] ` <20220216192037.2F236C00894@vcs2.savannah.gnu.org>
2022-02-16 20:50 ` master b299c04201: Fix computation of outline heading level for non-git diff Stefan Monnier
2022-02-17 7:21 ` Matthias Meulien [this message]
2022-02-19 19:06 ` Stefan Monnier
2022-02-20 8:02 ` Matthias Meulien
2022-02-20 14:36 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735kim00e.fsf@gmail.com \
--to=orontee@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.