From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds Date: Fri, 08 Apr 2022 07:38:05 +0800 Message-ID: <8735ioxy5e.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> <87k0c9imvp.fsf@yahoo.com> <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Eli Zaretskii , 54564@debbugs.gnu.org To: Pieter van Prooijen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 08 01:39:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncbiv-00024o-1J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Apr 2022 01:39:33 +0200 Original-Received: from localhost ([::1]:59358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncbit-0004jv-JC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Apr 2022 19:39:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncbiS-0004jT-Ak for bug-gnu-emacs@gnu.org; Thu, 07 Apr 2022 19:39:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncbiP-000700-ON for bug-gnu-emacs@gnu.org; Thu, 07 Apr 2022 19:39:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ncbiP-0003jx-Lv for bug-gnu-emacs@gnu.org; Thu, 07 Apr 2022 19:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Apr 2022 23:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54564-submit@debbugs.gnu.org id=B54564.164937470114322 (code B ref 54564); Thu, 07 Apr 2022 23:39:01 +0000 Original-Received: (at 54564) by debbugs.gnu.org; 7 Apr 2022 23:38:21 +0000 Original-Received: from localhost ([127.0.0.1]:33632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncbhl-0003iw-7v for submit@debbugs.gnu.org; Thu, 07 Apr 2022 19:38:21 -0400 Original-Received: from sonic304-22.consmr.mail.ne1.yahoo.com ([66.163.191.148]:39546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncbhj-0003ii-Hl for 54564@debbugs.gnu.org; Thu, 07 Apr 2022 19:38:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649374693; bh=NmP5Pki4+tH2CroP21O8KUTOMnLI7HKxPG8U5aaWTPM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=obCp5W4ARt20mvacf0AaMA9blRvJE1BWdAuv63NEOYYt2bVa7hMp7RIN/z9MXhHOdVchq64ORe8jMIg9qpdvPcvnt96hiLdk/jrM0qOzAntp7C1EawVrwF2z08kECsVrp/+6xOH3SbGyqGdrHxGlAubJ6DEYcDLXVEc8j7Bve0+WNGVPu9TjIzGGk0lXaQYfEOPpHLeoGG719pihS5PGo0sh5Fepau3P6XJE3Gv55wKPY6MzAAaadBt9zdcaipMqzt96ijPPxQAj/8iYwDGvkX50/77elIuCBjIkY1WxLB1EJ1eAixtUo85NYsT5WauOpQfVkMHz/1Eh+H76WAR4Wg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649374693; bh=H1SDbhJhzz41UwovJ1wj3JD6wLxv1ct+FCFwd15M23O=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=VecrdMc+ZYwzBEEp3m2yIefGvRFVGWALybvWPKnIiYu+wRL5d0K0D9E268J09ARKRsbtTT/aiZVC8Jhbwo45HCF63I3GUZy3pGmukrJcKQ8Lo6PX3hu0YkjE7LfPXbGaoFp1+NV6HdiHjgzqtv0jeLWS71E4XnV/eXlWyx7R4FI7/TDGNNMFpibARgcB0clIjqPdzioHngjYjmh2I2nGQ/5KPV1b/a8jySgLT/+O6S3hBZ7aD8NBsEskc8SAZ6i6HdW+M/0tqZzIuxowtfDOrgCindQkzoCLAO4WfL4il/9c/OUPGb/CH6AyQSTOaO9TK9xMpYcl1V5WUH1eMzHX3w== X-YMail-OSG: 4Qj.KcEVM1ni4YFRdnBvYCpQUUAJdRWw723YTafdh.HQd3Ju3aQajxRyBmS2cZU 63o4Jzz0JU_6mZZ9IN7mNRkVMNjc1PAUotQggdSxQn8NNwkw8llclVV2V5kQlhGyVPBT6S6e538s 6tL0CJueeYONMdH.PdV36MYDTzwtZQMXp3oU.x6g2cm.ewpSkXuDfLuKGMYMfk1OyNoWCDk9jf7y RmYZ1JwUjff1uQsx.46.I_OMa0oJVm0nYVXuYgMTDGvtx4rZXyrGxowouoQP9akUuYt_gnTjKiYR czR2jCljnJHv643k0KExYJERa1acCFlXmp1HcU8WfuW06ssM9GH3yRDee16bfKSuv8upauUQCiHq F1WYjEMWw_2Wqw0jtHhYeRvwlsnMjukFmJTokbiE0Nwa1.EsLfzLvs0HR.AEv7XsiSfyrlEi8CZk nFqBhNy3k.YOU7VtltzTfaHfKS49dCg22NRDNLgPIufFWXtwUIj.Za55coTgrAEB5GzAmJ0picbC ryjWuHT37MuFGtvY5TVUzZZp8ygiv49D3BvvXoJx8xFkynXumUx3G5b4Abldmp73PbteyivYDdQl qPbHdiHmlPnsZzvFec8Yw6cNlXmkUwSTmckjy6QiUkciwzTqoy65NsDUTmGti1oieGQdYI5WLmbJ 3aC5V9HWPVlTlBF6ztmyf8OShfGRjyQM_3Spg4VUUzGwAv6PchGssBgLe_8MiHHyreazUeVDnY3Z K47._K0jIuV7wyah30.yT1Au3WIupI7Pz_dH8G8cYb_0UNqxjSCwaQ0Z3NzsTE5t_1Xl_vZaYrQN _YVHkOh7GCXlDHySfBXkT6HeTBKKxtbFCNdNngOE1U X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Thu, 7 Apr 2022 23:38:13 +0000 Original-Received: by hermes--canary-production-sg3-65d7bd97b5-gqv44 (VZM Hermes SMTP Server) with ESMTPA ID 674d9332323d063d07fdad5ba1c61005; Thu, 07 Apr 2022 23:38:09 +0000 (UTC) In-Reply-To: <66a9a7d83ca545dd23c890d4aa97717f1796579f.camel@teloden.nl> (Pieter van Prooijen's message of "Thu, 07 Apr 2022 21:24:28 +0200") X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229547 Archived-At: Pieter van Prooijen writes: > Hi All,=C2=A0 > > It took a fair bit of digging, but sub-pixel anti-aliasing on pgtk now > seems to work correctly. > > The problem lies with the "source" operator set by pgtk when drawing a > font, this will take a particular execution path in the cairo glyph > compositor (using a mask image) which converts the colors created by > freetype for the sub pixel effect to greys-cale. Using the default > "over" operator takes a different path which preserves the colors. Note > that on small screens the difference between sub-pixel and grey-scale > rendering is hard to see, it's more pronounced on larger displays) Ah thanks. Does this fix the problem as well? diff --git a/src/pgtkterm.c b/src/pgtkterm.c index b2816aa04a..5fbc56ae81 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -7037,8 +7037,11 @@ pgtk_set_cr_source_with_color (struct frame *f, unsi= gned long color, pgtk_query_color (f, &col); =20 if (!respects_alpha_background) - cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red / 65535.0, - col.green / 65535.0, col.blue / 65535.0); + { + cairo_set_source_rgb (FRAME_CR_CONTEXT (f), col.red / 65535.0, + col.green / 65535.0, col.blue / 65535.0); + cairo_set_operator (FRAME_CR_CONTEXT (f), CAIRO_OPERATOR_OVER); + } else { cairo_set_source_rgba (FRAME_CR_CONTEXT (f), col.red / 65535.0, > I've also fixed the indent error, but couldn't find the non-breaking > space in the patch, it's perhaps caused by the mail program. It was previously filled with non-breaking spaces, but the patch you attached looks fine now. > Regarding the copyright assignment, I've had no response after sending > in the questionnaire at > https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-= assign.future > to assign@gnu.org It takes a while; if you don't get a response in 2 weeks, you should contact Eli or Lars, and they will ask the folks at the FSF to expedite things. > Do you get sent a paper form of some kind which has to be filled in? > (I'm not at my home address atm so I will have missed that) You get sent a document you have to print and fill in, I think, but that depends on the country you're in. Thanks.