From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too
Date: Mon, 11 Apr 2022 15:04:40 +0200 [thread overview]
Message-ID: <8735ijbwk7.fsf@gnus.org> (raw)
In-Reply-To: <874k2z3hj8.fsf@yahoo.com> (Po Lu's message of "Mon, 11 Apr 2022 20:56:27 +0800")
Po Lu <luangruo@yahoo.com> writes:
> The object might be garbage collected, and another one could be consed
> with the same type tag and address as the original.
It seems rather unlikely -- especially since it's also checking that the
index is the expected one.
> So we should probably mark that data upon garbage collection.
For the imagemagick cache, we're just using a cookie, that's basically
what we're doing here, too. Perhaps sxhashing the spec and using that
instead would be fine, but it's slower, and we don't really care that
much about correctness here -- we're just using this to speed things up,
after all.
So I dunno. My only worry was that not gc-protecting it might lead to a
segfault somewhere.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-04-11 13:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org>
[not found] ` <20220411113602.7A114C0581E@vcs2.savannah.gnu.org>
2022-04-11 12:15 ` master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Po Lu
2022-04-11 12:44 ` Lars Ingebrigtsen
2022-04-11 12:56 ` Po Lu
2022-04-11 13:04 ` Lars Ingebrigtsen [this message]
2022-04-11 13:12 ` Po Lu
2022-04-11 13:15 ` Lars Ingebrigtsen
2022-04-11 13:29 ` Po Lu
2022-04-11 13:58 ` Stefan Monnier
2022-04-11 14:55 ` Lars Ingebrigtsen
2022-04-11 13:12 ` Eli Zaretskii
2022-04-11 13:14 ` Lars Ingebrigtsen
2022-04-11 13:22 ` Eli Zaretskii
2022-04-11 13:25 ` Po Lu
2022-04-11 13:29 ` Eli Zaretskii
2022-04-11 13:32 ` Po Lu
2022-04-11 14:55 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ijbwk7.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.