From: Philip Kaludercic <philipk@posteo.net>
To: 54931@debbugs.gnu.org
Subject: bug#54931: [PATCH] Have submit-emacs-patch prompt for patch file before subject
Date: Thu, 14 Apr 2022 10:16:11 +0000 [thread overview]
Message-ID: <8735ig55sk.fsf@posteo.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
Tags: patch
When sending patches using submit-emacs-patch, I usually want to reuse
the commit title for the message subject. As a minor convenience, this
can be guessed when the patch file is prompted before the subject,
allowing for a default value to be provided by extracting the "Subject"
header from the patch file.
In GNU Emacs 29.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
of 2022-04-10 built on viero
Repository revision: 0023cfdc4e6d348519198cf75553d1afad0ed153
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Guix System
Configured using:
'configure
PKG_CONFIG_PATH=/home/philip/.guix-profile/lib/pkgconfig:/home/philip/.guix-profile/share/pkgconfig'
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Have-submit-emacs-patch-prompt-for-patch-file-before.patch --]
[-- Type: text/patch, Size: 1302 bytes --]
From 5a0509166c184178f65506615db225eac9426e41 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Thu, 14 Apr 2022 12:13:27 +0200
Subject: [PATCH] Have submit-emacs-patch prompt for patch file before subject
* emacsbug.el (submit-emacs-patch): Prompt for patch file and use that
to guess the subject.
---
lisp/mail/emacsbug.el | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index 1bda609d10..3cc727e6cf 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -488,7 +488,14 @@ submit-emacs-patch
Interactively, you will be prompted for SUBJECT and a patch FILE
name (which will be attached to the mail). You will end up in a
Message buffer where you can explain more about the patch."
- (interactive "sThis patch is about: \nfPatch file name: ")
+ (interactive
+ (let* ((file (read-file-name "Patch file name: "))
+ (guess (with-temp-buffer
+ (insert-file-contents file)
+ (mail-fetch-field "Subject"))))
+ (list (read-string (format-prompt "This patch is about" guess )
+ nil nil guess)
+ file)))
(switch-to-buffer "*Patch Help*")
(let ((inhibit-read-only t))
(erase-buffer)
--
2.34.0
[-- Attachment #3: Type: text/plain, Size: 24 bytes --]
--
Philip Kaludercic
next reply other threads:[~2022-04-14 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 10:16 Philip Kaludercic [this message]
2022-04-14 13:52 ` bug#54931: [PATCH] Have submit-emacs-patch prompt for patch file before subject Lars Ingebrigtsen
2022-04-14 16:41 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ig55sk.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=54931@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.