Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Sean Whitton]

Hello,

On Sun 24 Apr 2022 at 09:16am -04, Lars Ingebrigtsen wrote:

> +
> +If the user aborts (with `C-c C-d'), ABORT-CALLBACK (if any) is
> +called with no parameters.

I think C-c C-k would be more consistent with other modes?

-- 
Sean Whitton

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Lars Ingebrigtsen]

Sean Whitton <spwhitton@spwhitton.name> writes:

>> +If the user aborts (with `C-c C-d'), ABORT-CALLBACK (if any) is
>> +called with no parameters.
>
> I think C-c C-k would be more consistent with other modes?

Yup; now altered.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Jean Louis]

I am using similar function all the time.

(defun read-from-buffer (&optional value buffer-name mode title keymap place highlight-list minor-modes)

I suggest you implement some of these features:

- I like to designate offen the buffer-name, it becomes more
  descriptive

- Some text is in different modes, some strings are in html-mode, some
  are in markdown-mode, some in asciidoc mode, some are SQL mode, and
  so on;

- I may need to pass keymap to function

- I pass some minor-modes when necessary

PLACE is something related to database, like database, column, ID,
when I edit database objects, it is not related and not necessary to
this general function


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Stefan Monnier]

Jean Louis [2022-04-29 12:44:41] wrote:
> (defun read-from-buffer (&optional value buffer-name mode title keymap place
> highlight-list minor-modes)

I'd collapse those "mode title keymap place highlight-list minor-modes"
into a singe `setup-function` argument.

And FWIW, `read-from-buffer` sounds like a good name for a "low-level"
function that parallels `read-from-minibuffer` but using a normal window
rather than a miniwindow, whereas `read-string-from-buffer` sounds like
a replacement for `read-string` (and hence wouldn't take/need
a `setup-function` argument).


        Stefan

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Jean Louis]

* Stefan Monnier <monnier@iro.umontreal.ca> [2022-04-29 15:21]:
> Jean Louis [2022-04-29 12:44:41] wrote:
> > (defun read-from-buffer (&optional value buffer-name mode title keymap place
> > highlight-list minor-modes)
> 
> I'd collapse those "mode title keymap place highlight-list minor-modes"
> into a singe `setup-function` argument.

Is there example of that to help me understand it?

Do you mean `setup-function` should be a list or hash, or similar data
type which is then parsed by function?


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Stefan Monnier]

Jean Louis [2022-04-29 16:18:48] wrote:
> * Stefan Monnier <monnier@iro.umontreal.ca> [2022-04-29 15:21]:
>> Jean Louis [2022-04-29 12:44:41] wrote:
>> > (defun read-from-buffer (&optional value buffer-name mode title keymap place
>> > highlight-list minor-modes)
>> 
>> I'd collapse those "mode title keymap place highlight-list minor-modes"
>> into a singe `setup-function` argument.
>
> Is there example of that to help me understand it?
>
> Do you mean `setup-function` should be a list or hash, or similar data
> type which is then parsed by function?

No, I mean a formal argument called `setup-function` which
`read-from-buffer` would call (probably with 0 arguments) in the buffer.

So instead of:

    (read-from-buffer "My prompt: " "*The Buffer*"
                      #'foo-mode nil foo-map nil nil (list #'bar-minor-mode))

you'd write:

    (read-from-buffer "My prompt: " "*The Buffer*"
                      (lambda ()
                        (foo-mode)
                        (use-local-map foo-map)
                        (bar-minor-mode 1)))


-- Stefan

Re: master 8ee21db4af: Add new function `read-string-from-buffer'.

[Jean Louis]

* Stefan Monnier <monnier@iro.umontreal.ca> [2022-04-29 16:54]:
> Jean Louis [2022-04-29 16:18:48] wrote:
> > * Stefan Monnier <monnier@iro.umontreal.ca> [2022-04-29 15:21]:
> >> Jean Louis [2022-04-29 12:44:41] wrote:
> >> > (defun read-from-buffer (&optional value buffer-name mode title keymap place
> >> > highlight-list minor-modes)
> >> 
> >> I'd collapse those "mode title keymap place highlight-list minor-modes"
> >> into a singe `setup-function` argument.
> >
> > Is there example of that to help me understand it?
> >
> > Do you mean `setup-function` should be a list or hash, or similar data
> > type which is then parsed by function?
> 
> No, I mean a formal argument called `setup-function` which
> `read-from-buffer` would call (probably with 0 arguments) in the buffer.
> 
> So instead of:
> 
>     (read-from-buffer "My prompt: " "*The Buffer*"
>                       #'foo-mode nil foo-map nil nil (list #'bar-minor-mode))
> 
> you'd write:
> 
>     (read-from-buffer "My prompt: " "*The Buffer*"
>                       (lambda ()
>                         (foo-mode)
>                         (use-local-map foo-map)
>                         (bar-minor-mode 1)))
> 

I got that, thank you. That is generally good idea for some functions
that require more arguments.


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/