From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Date: Wed, 04 May 2022 09:48:55 +0200 Message-ID: <8735hpwxeg.fsf@gnus.org> References: <4d1b8687-20f2-137a-2739-7bba28828991@daniel-mendler.de> <87wnf5mpt4.fsf@gnus.org> <87k0b5duzh.fsf@gnus.org> <8735htdrmt.fsf@gnus.org> <87wnf49ww8.fsf@gnus.org> <87k0b2zzxr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Daniel Mendler , Eli Zaretskii , 55205@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 04 09:53:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nm9ou-0009zw-Ac for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 May 2022 09:53:12 +0200 Original-Received: from localhost ([::1]:41432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nm9or-0004J3-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 May 2022 03:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm9ls-00012w-1t for bug-gnu-emacs@gnu.org; Wed, 04 May 2022 03:50:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nm9lq-0000u6-0M for bug-gnu-emacs@gnu.org; Wed, 04 May 2022 03:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nm9lp-0000ug-VC for bug-gnu-emacs@gnu.org; Wed, 04 May 2022 03:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 May 2022 07:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55205 X-GNU-PR-Package: emacs Original-Received: via spool by 55205-submit@debbugs.gnu.org id=B55205.16516505493441 (code B ref 55205); Wed, 04 May 2022 07:50:01 +0000 Original-Received: (at 55205) by debbugs.gnu.org; 4 May 2022 07:49:09 +0000 Original-Received: from localhost ([127.0.0.1]:41656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nm9kz-0000tR-0j for submit@debbugs.gnu.org; Wed, 04 May 2022 03:49:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nm9kx-0000tF-8T for 55205@debbugs.gnu.org; Wed, 04 May 2022 03:49:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fD6Q/Ygjq6vShspIfAwnutILYRZ9TxoUmsx7Yffxbgs=; b=tQi5ExZWeOzRxIN0grmPpUIvZM ydJM8L9sf2pGRqJn+riyH38EHLLJt51+SEZTBCzkz47MP/fulphI0ojVHNZmRKXgdRAp1zdhvGRpD EhHt3lXP56+EMyo0M3NAw+l1ViLMl2W/kNYdxH4kxElAEfequ1mQMGT5NvzSX37v37iI=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nm9km-0008Lb-Ln; Wed, 04 May 2022 09:48:59 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVpQUqNbGehgnmr j4ykPFb////1tcpiAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YFBAcqAs9h8ZkAAAG7SURBVDjLbZOL ecMwCIRR3QEALRChBWqpA3T/qXqAZLsPJfmS6AcdcDIVMR0qWNbnnPgMfM1BImpTzcbwvT7Ooh4w AUSbrNX6/KBjZbBIYbzxEul9gdMzpID6NnTmC6BDhoo81xwAY5j0J1CIGdNh0Bz0jFdEAgwzMSp3 TYirlekN5Zr91FDFUepdyi/QAQT7dT41mjRtjMMtRxL17xRhP6P1884gX4Vpr62RO4XeP/8Fwsf8 BST/MH09AKKvgl38zrhARbmKdhoahBkO/AWwq3Yg7pUQpyPeuSmmGxqPubxI+2kiS9xtDIrpljrQ u5ee8WVnvCmcGlkPRRqnxqFznKjHEzwNzbg+jKowquUc4k1xlXzsZwBXxikZ7gBN9BBfwIsoPhLV NYwYTl65EhmzntH5AviB+2I+UAD13Q2Yo9x3H9XapYJxHlwWwLVwgLO8TZLXNR65AIJJWgmjbsCF 1r0ygVHpCfljsw30JycaXBm3szH2uH2a4GEUMmpbR+l2sIV4lXOBq8TMqG3kUZRGXfequsgfYFdV YTm5r9nO3aADTlOdAPgDEpWGc1sjnUvA9+VJwNn5I/4xxG+tY0pqahonDQAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMi0wNS0wNFQwNzo0MjowMiswMDowMJa32oEAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjItMDUtMDRUMDc6NDI6MDIrMDA6MDDn6mI9AAAAAElFTkSuQmCC X-Now-Playing: Simple Minds's _New Gold Dream (81-82-83-84)_: "Colours Fly and Catherine Wheel" In-Reply-To: (Stefan Monnier's message of "Tue, 03 May 2022 08:55:37 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231371 Archived-At: Stefan Monnier writes: >> But I still have no idea why we're stripping text properties in the >> first place, so could you please explain that? > > It depends where. In `completion--replace` it's explained in the > comment: > > ;; The properties on `newtext' include things like the > ;; `completions-first-difference' face, which we don't want to > ;; include upon insertion. So it's really about stripping modifications that completion has already done to the strings? Well, that seems like an easy enough problem to deal with -- just remove those, and leave the rest of the text properties alone. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no