From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: contovob@tcd.ie, emacs-devel@gnu.org, gregory@heytings.org
Subject: Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling.
Date: Sun, 24 Jul 2022 14:10:33 +0200 [thread overview]
Message-ID: <8735eqaeyu.fsf@gmail.com> (raw)
In-Reply-To: <831quahgze.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jul 2022 14:45:09 +0300")
>>>>> On Sun, 24 Jul 2022 14:45:09 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org, gregory@heytings.org
>> Gmane-Reply-To-List: yes
>> Date: Sun, 24 Jul 2022 13:14:21 +0200
>>
>> Apropos, is there an ʼupdating pdumper stuff for dummiesʼ guide
>> somewhere? Something along the lines of:
>> - if you add an int to struct <foo>, do <bar>
>> - if you add a Lisp_Object to struct <baz>, do <frot>
>>
>> I ask, because Iʼm playing with struct buffer_text, and Iʼm very
>> successfully causing 'failure to dump' :-)
Eli> The error message points you to the comment in config.h that is
Eli> supposed to be the "updating pdumper stuff for dummies" guide:
Eli> error: #error "buffer changed. See CHECK_STRUCTS comment in config.h."
Sorry, I wasnʼt clear. That just fixes the compile error, it doesnʼt
cover the second part, which is to ensure that your new field is
dumped/restored correctly. For a struct Lisp_Hash_Table *,
DUMP_FIELD_COPY is not enough.
Robert
--
next prev parent reply other threads:[~2022-07-24 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165799889678.19490.7919197387382513250@vcs2.savannah.gnu.org>
[not found] ` <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org>
2022-07-23 11:40 ` feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling Basil L. Contovounesios
2022-07-23 13:20 ` Eli Zaretskii
2022-07-23 13:51 ` Basil L. Contovounesios
2022-07-24 11:14 ` Robert Pluim
2022-07-24 11:45 ` Eli Zaretskii
2022-07-24 12:10 ` Robert Pluim [this message]
2022-07-25 20:50 ` Gregory Heytings
2022-07-26 11:07 ` Eli Zaretskii
2022-07-26 11:28 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735eqaeyu.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.