From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 70341cab3e: string-equal-ignore-case: new function Date: Tue, 26 Jul 2022 19:58:06 +0200 Message-ID: <8735en21u9.fsf@gnus.org> References: <165885780615.5477.9618918327695992186@vcs2.savannah.gnu.org> <20220726175007.02EE9C00095@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27012"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Sam Steingold Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 26 20:00:08 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGOql-0006re-2s for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 20:00:07 +0200 Original-Received: from localhost ([::1]:54772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGOqk-0003X9-3T for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 14:00:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGOpC-0002ci-LR for emacs-devel@gnu.org; Tue, 26 Jul 2022 13:58:31 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:59622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGOow-0005sg-VQ; Tue, 26 Jul 2022 13:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oe8o6y2dimsS+4nn0NjfD1e7KsaUwV91IGmstC02uuc=; b=rR2FZZMuAx6CmRh9YE7emnU2l2 08405AjIpl/KmS+ZN5F+F1ARNlgkdapHCsdThmoYqgnXGyk/+xHPOMPU51maru1Vxi0LQ/y4bx4BD FtiY9wGLDXc0bq3dKxwQC1iCPVV/W8iQjlVb5iUivjIes8XYuRNQvwO2/Ui8FNhpting=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGOoq-0008Mt-Nx; Tue, 26 Jul 2022 19:58:11 +0200 In-Reply-To: <20220726175007.02EE9C00095@vcs2.savannah.gnu.org> (Sam Steingold's message of "Tue, 26 Jul 2022 13:50:06 -0400 (EDT)") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUHBQUxJh5eTz2j jWnizqD////HW1jiAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YHGhE4GnZUtRIAAAG7SURBVDjLvVPb deUgDAScAgy4ACNcgEEqYI3Uf00rjH2vk81+Jhz40TAaPY35ieNDTd+YXSYRaetXe+jmjvzHLszz 026RapZvOOp/NREHbX8Io0gxdrckJMhvIIpkxhVMrCSVXhT9yLPPXPUBwVtlGoqRVISK0u/AshBX UCkVb2V6yVtij8J1NpvmsTqR44pJarGaBXtl1KQA3xJYzHzlvtbIt0hGrCnMHk5gdkCXyBbURJqg 8Kmrvv6cAHlkzSRNnVHUNQ11S2UDzZjpAj54pGgruoVRxQ9ppH8/rgpbhrQJu6gSJ3DHaxHbIno5 8tbFNZ0L8AByKGnao/SeLzfgVqSE1JYDUjBd5BJfWi/SdlCRPZTZbnXMStkOAGolaSsKs3fSRknW WDzHPaGAaJUXfYNhIUcJq8sarT51i4NhRRQImbRUiQ4S718tBw5T23YNWVLvibkZDEVD27MCfbiu DhqiEa1+nrPkN7CcvSuqJB7oMYvuHFnbgdgavcenT4cwSiFe5ro9xnqSe9IXKCSP5XltR9Bwn3vg BsLEHPjTtsXhiVrUGft0rn06cv26nSdSAf7d54CIq/nV8xeU0nvPV3dndgAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMi0wNy0yNlQxNzo1NjoyNiswMDowMFKf1HYAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjItMDctMjZUMTc6NTY6MjYrMDA6MDAjwmzKAAAAAElFTkSuQmCC X-Now-Playing: Scritti Politti's _Early_: "Skank Bloc Bologna" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292711 Archived-At: Sam Steingold writes: > -;; case-insensitive case, but it has to cope with null args. > -;; (`string-equal' uses symbol print names.) > -(defun gnus-string-equal (x y) > - "Like `string-equal', except it compares case-insensitively." > - (and (= (length x) (length y)) > - (or (string-equal x y) > - (string-equal (downcase x) (downcase y))))) We don't remove non-internal functions like this (because they may be used by third parties). Instead make it obsolete. > - (when (gnus-string-equal > + (when (string-equal-ignore-case > (message-fetch-field "followup-to") > (message-fetch-field "newsgroups")) And the arguments here may be nil, which will signal an error.