From: Stephen Berman <stephen.berman@gmx.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: daanturo <daanturo@gmail.com>, 57176@debbugs.gnu.org
Subject: bug#57176: 29.0.50; Commit 744ed0ce applies outline-minor-mode-highlight-buffer repeatedly
Date: Wed, 17 Aug 2022 09:57:59 +0200 [thread overview]
Message-ID: <8735dvfgjc.fsf@rub.de> (raw)
In-Reply-To: <87edxi9cly.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 15 Aug 2022 09:42:33 +0200")
On Mon, 15 Aug 2022 09:42:33 +0200 Lars Ingebrigtsen <larsi@gnus.org> wrote:
> daanturo <daanturo@gmail.com> writes:
>
>> I think we should clear old outline overlays before applying new ones,
>> or adjust the conditions like the old one.
>
> I guess this might be the result of this change?
>
> - (if (and global-font-lock-mode (font-lock-specified-p major-mode))
> - (progn
> - (font-lock-add-keywords nil outline-font-lock-keywords t)
> - (font-lock-flush))
> - (outline-minor-mode-highlight-buffer)))
> + (when (and global-font-lock-mode (font-lock-specified-p major-mode))
> + (font-lock-add-keywords nil outline-font-lock-keywords t)
> + (font-lock-flush))
> + (outline-minor-mode-highlight-buffer))
>
> I've added Stephen to the CCs; perhaps he has some comments.
Sorry for the late response. Juri Linkov already noted a probably
related problem with my patch, see <86sfm4q6nu.fsf@mail.linkov.net>.
I'm afraid my reply to his message still holds:
>> I'm not familiar enough with the intricacies of font-lock to whip
>> up a quick fix and can't afford to spend a lot of time on it, so I hope
>> someone better qualified than me will do it.
Juri replied to that:
> I guess what is needed here is to find the right place to call
> outline--fix-up-all-buttons on first visiting the NEWS buffer.
but I haven't had time to look into that, nor whether that would also
work for bug#57176.
Steve Berman
next prev parent reply other threads:[~2022-08-17 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 14:10 bug#57175: 29.0.50; Commit 744ed0ce applies outline-minor-mode-highlight-buffer repeatedly daanturo
2022-08-15 7:42 ` bug#57176: " Lars Ingebrigtsen
2022-08-17 7:57 ` Stephen Berman [this message]
2022-08-30 17:09 ` Juri Linkov
2022-08-30 19:13 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735dvfgjc.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=57176@debbugs.gnu.org \
--cc=daanturo@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.