From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 2385bf3397: Treat smtp-auth method from auth-info as a symbol Date: Thu, 25 Aug 2022 17:19:49 +0200 Message-ID: <8735dkz6y2.fsf@gmail.com> References: <166143376789.20998.11367094880977429471@vcs2.savannah.gnu.org> <20220825132248.2C126C0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20848"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 25 17:21:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oREfb-0005IM-Sb for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 17:21:23 +0200 Original-Received: from localhost ([::1]:44740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREfa-0002MW-PR for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 11:21:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oREeB-0001cg-0k for emacs-devel@gnu.org; Thu, 25 Aug 2022 11:19:55 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:36654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oREe9-0004af-Gn for emacs-devel@gnu.org; Thu, 25 Aug 2022 11:19:54 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id v7-20020a1cac07000000b003a6062a4f81so2892343wme.1 for ; Thu, 25 Aug 2022 08:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:to:from:from:to:cc; bh=mzwvjhaX8OxJyK0dWMH8kS9yEW9HqQHrU3Y134nmaLc=; b=EGs52fqRTVGsu9p6Z6Ge2Iz3VAVtsQOXn8G602V4t32q088ZekszTpqnQBbhveRIS6 tbCuArQRzJldZPRybAvhImHH+XybqB7ohRhYir4M3kMBXRd/LYh+2VxUK5nf76pn+ISC IdYCPqHp1T0DeVySl/FFJBGoJOnrvOAHyq9G3dj5xOiIrL9WXWL9grgx/KznmwMKrnal QU7rdLeN8TG3E4abq2gBquDT+BqQmWEKJ1eUfIV3/S40Cqh8Uu+Ud1/JTKjuXrIBtDLF rmjrPQ8KObH1jUd554E3T6EpO5icX5Anwarg6r4Yv6AtsgqJJsCSw7ShATjnSb4Eug79 BmLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc; bh=mzwvjhaX8OxJyK0dWMH8kS9yEW9HqQHrU3Y134nmaLc=; b=QDUf5B/P3b8bTFRGSuOFwi92thOkX0tDciYacvmYxCkpBskF50KG3B1pDiH1LJGZ7m W3ocgWSYCF6qblwIRRh0a47lo7oZT2FX6HNwv7owl9O9loIs8XNpE1t+HBo9/HZSbJqq RP9IjNMhTrBs+96tgQ2veQCXdoGMo1p+I93sUNHbFYtjG3grcbz9tCITZ1i/i4HZf9wh 6vQoLd73WUjZx8L4LCW0wCs4vq49CGf/dc+VKTLEiio6eNZTddny4zJ5YvUE4DSBCSc+ d8a56JAnc8Sv79kbWU+sNgHstBERNEQYmCLVHFPu/gEjNdJrE4pTgwsDzTz65eUMya1X OtJw== X-Gm-Message-State: ACgBeo0sWrrBl7pvH7hlhNi2QuRqkSyvshuw6Tp+bSYoZKOpVRFrOBhm IweucNpun6MkdAFNe+wP95Y91rpPnk0= X-Google-Smtp-Source: AA6agR4269VREZ3FSRq+9dSxfvIlD2YhTboBFUsnCNNTeFoM49QkVRhoEm5bZoOHkhx0qUH6TpKdXQ== X-Received: by 2002:a05:600c:310b:b0:3a6:8970:27fc with SMTP id g11-20020a05600c310b00b003a6897027fcmr2651188wmo.98.1661440791251; Thu, 25 Aug 2022 08:19:51 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:c9cb:47b6:7fdd:18c5]) by smtp.gmail.com with ESMTPSA id i11-20020adffdcb000000b0021eed2414c9sm19640330wrs.40.2022.08.25.08.19.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:19:50 -0700 (PDT) In-Reply-To: <20220825132248.2C126C0088A@vcs2.savannah.gnu.org> (Robert Pluim's message of "Thu, 25 Aug 2022 09:22:48 -0400 (EDT)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294089 Archived-At: >>>>> On Thu, 25 Aug 2022 09:22:48 -0400 (EDT), Robert Pluim said: Robert> branch: master Robert> commit 2385bf3397f8a92e226a29a5050c69dd8d2a1c31 Robert> Author: Robert Pluim Robert> Commit: Robert Pluim Robert> Treat smtp-auth method from auth-info as a symbol Robert> The lookup of the SMTP auth method is done based on symbols, but Robert> sometimes the requested value comes from `auth-info', in which case it Robert> is a string, so call `intern-soft' to convert it to a symbol (which Robert> does nothing if it's already a symbol). I just realised this is a feature introduced in emacs-28, not emacs-29, so perhaps a similar fix should go to the release branch as well? Robert --