From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58288: 29.0.50; (flyspell-correct-word-before-point) followed by crashes emacs Date: Wed, 05 Oct 2022 18:46:48 +0800 Message-ID: <8735c2wns7.fsf@yahoo.com> References: <877d1f3kgj.fsf@gnus.org> <83tu4jvkfz.fsf@gnu.org> <87zgeb91ac.fsf@gmail.com> <83mtabvgxw.fsf@gnu.org> <87pmf78vta.fsf@gmail.com> <83fsg3v9fb.fsf@gnu.org> <87k05e8u8w.fsf@gmail.com> <83fsg2twhv.fsf@gnu.org> <87fsg28sxt.fsf@gmail.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 58288@debbugs.gnu.org, Eli Zaretskii , ajd2195@columbia.edu, larsi@gnus.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 05 12:57:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1og25P-00074F-Qy for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 12:57:11 +0200 Original-Received: from localhost ([::1]:35834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og25O-0001Fl-US for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 06:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og1wZ-0005HU-Bu for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 06:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1og1wZ-0002VW-1g for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 06:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1og1wY-0005z4-Tk for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 06:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Oct 2022 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58288 X-GNU-PR-Package: emacs Original-Received: via spool by 58288-submit@debbugs.gnu.org id=B58288.166496682322783 (code B ref 58288); Wed, 05 Oct 2022 10:48:02 +0000 Original-Received: (at 58288) by debbugs.gnu.org; 5 Oct 2022 10:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:56014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og1vb-0005vP-42 for submit@debbugs.gnu.org; Wed, 05 Oct 2022 06:47:03 -0400 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:39289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og1vZ-0005uq-7a for 58288@debbugs.gnu.org; Wed, 05 Oct 2022 06:47:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664966815; bh=fQqBnXIQynTM2VR5KXE71qmNfdpPeyVV9IJwWm9dxCQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=dxeFcYWhjmnbKBDECdBt8oWo5h2mHW0xd3PmPfWKHTq9oBwuWUEvhYwbdcqjYlB5s9UIniT8SncpZw0aDJD2OFhAMsqFmcJLf3Nhhv/+tz5sXDvHW42BVr+xBjXGv0lRL/3klxVzjiCiunXdPNrzapqbRnn7JvNOv67f/QGdezzUQCLa66BFwBHCtRixnaV/rlKcVMh1S6fiffF2wEYGlOp0ujzBHtXKE2BzP22LMFSJdJR3oNbcYjXuiTwbZ7WWvv0IUGRAxoNk/eSJB2TuNoFsEH59bQ8m+QUuBFQAe159QUZUJaXyfLU4Km9GRJ1knzJe+i6rhyP/jTZwyRbXhQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664966815; bh=JkBQezCCBa1yjWF2NUb/6PMriKmqPFDg+67HGn7tAXy=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=svcQ7liml6XQ5SVTX9/q0kcZ720qUVPpwWTtY13Ou17NDglfIoLPrfmK49LInKJNx/QCVf4h1kMOXR8dUgq2so65ujSulmz8+nrD/N05VNcFvmQMWJMz5hD5kqva2LimX4ss0tu6XkTU3lZKs3aS/P2fWoZ1hGJhhFjiRbaTf7+TrHS0tii3xHuAlVEdrvvj7cLrAYT3FqLXAWIhrFqu97M7nKgLyJcrN99S3nU65ZTORkbtKNnb09hjFKZPFWDyyn636w/Kxz1nbKmzqm4T2s65HAbQp7sPbIFKikiHfaLJm5OXwAF0hPlSRMaUtiNB0hwXTEz2gs2Hf+64tBEcuw== X-YMail-OSG: 0rqvxeYVM1lE7WXoX7eAJNv0uZevVdcq.fFg2NcNv1Ef4hgXokrWaKmNXBIchb7 da.xR5tpTyZhct3jsLgxZNkfUahg7yOsuGZTmGlwCkOPjg_4dqyIU6kSpvDPMHNpGL7iwfH0Pb2h PhArWCV8qJZIakpsv6g_9EXpAeraSnAR8pRTDWscaKZF1ENzHj6irMGdV_4Nb0BxIHxa02Q3p4jA Pk7PH6YUJWHBGI80n1eeU1un43WDAbQt76vxQgjyoVPPiY2IhZPqo8yMCIlZNYahjVV3t_058Kx3 jQK3qbJzN0sCLF3yliycloMy8YqTYODASs.Sk81LLx40up1G1BavXCO0L8bBTcSdcCjx7VJY4iqi pggcnbzIyAbiM5ZT5S8mcJvepQeIAEQu4.orNTOVtkvE.4n1.gIzQYsJU9Qb.EtXtfY1BO6o1TY3 voZu48Eqb4WWuvcFf8LYw929cJYz0qKrQJZfVMYIeEo0Ml7dWzbJxuOSnyQfGQxxJrQFPbzW0ODA JvsVUbEOqTuMSeMN0zYdQDYIlMXKhGSZ9s4jOCP7VqhnsKQQCsz8ffnZfSC3GV.lbrZHFQM948ZT .6fPLfKd4g4CZH1zUIEv3eBAQ4aFRQxxD1ThHJlmaBOLae_i46555YnKX7aMSqYjG_C7m4dzO7tN 6jHfvtv23HvkEZ4ENGTa_VnC_MZKQKZBnoDPA4ACAm7UCmzQG26zrwhoj9XZ4bDXU.aAg3GXkgQF ccGqx9Bbz2creGXBYxI3WHbnVfXVTr.f7mCNTao2cJy0SSLWPkfFoPDpSTsn6wrnLBs1HzCNMuMP ihn2DIa8TlgCa9VT36f8HpMar_WzpMe3fQqNL9k5bm X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Wed, 5 Oct 2022 10:46:55 +0000 Original-Received: by hermes--production-sg3-cf9dc7f8d-rww6r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5a2341298391e11394f441dba2042e59; Wed, 05 Oct 2022 10:46:53 +0000 (UTC) In-Reply-To: <87fsg28sxt.fsf@gmail.com> (Robert Pluim's message of "Wed, 05 Oct 2022 12:29:18 +0200") X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244511 Archived-At: Robert Pluim writes: >>>>>> On Wed, 05 Oct 2022 13:06:52 +0300, Eli Zaretskii sai= d: > >> void > >> save_menu_items (void) > >> { > >> Lisp_Object saved =3D list4 (menu_items_inuse ? menu_items : Qnil, > >> make_fixnum (menu_items_used), > >> make_fixnum (menu_items_n_panes), > >> make_fixnum (menu_items_submenu_depth)); > >> record_unwind_protect (restore_menu_items, saved); > >> menu_items_inuse =3D false; > >> menu_items =3D Qnil; > >> } > >>=20 > >> This fixes it, but it seems a bit dodgy to me, why has no other > >> platform ever run into this? > > Eli> How come a menu is in use, but menu_items_inuse is zero? > > `menu_items_inuse' is not zero, it=CA=BCs false. `menu_items_used' is > non-zero. I guess something called `unuse_menu_items', and the > assumption is then that `menu_items' will not be accessed (but then > why save away `menu_items_used' etc? > > menu.c says: > > /* Whether the global vars defined here are already in use. > Used to detect cases where we try to re-enter this non-reentrant c= ode. */ > bool menu_items_inuse; > > so should we be adding "if (menu_items_inuse)" guards everywhere? > > Robert No matter how much I try I cannot reproduce this (or bug#58296) on GNUstep, and I don't have access to Mac OS anymore. But after the holidays are over I will be able to test stuff on a Mac and will look into this. Thanks.