From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nacho Barrientos Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#59805: 28.2; erc-track: handle faces modified with erc-button-add-face Date: Tue, 06 Dec 2022 17:06:18 +0100 Message-ID: <87359sh53z.fsf@cern.ch> References: <87h6ycprpt.fsf@cern.ch> <87bkoglilv.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10705"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.9; emacs 28.2 Cc: 59805@debbugs.gnu.org, emacs-erc@gnu.org, git@david.leatherman.fm, Olivier Certner To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 06 17:26:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2alq-0002YT-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Dec 2022 17:26:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2alk-0005uJ-Ds; Tue, 06 Dec 2022 11:26:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2ale-0005pV-AF for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 11:26:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2ale-00050q-2b for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 11:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2ald-0005UD-Tf for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 11:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nacho Barrientos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Dec 2022 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59805 X-GNU-PR-Package: emacs Original-Received: via spool by 59805-submit@debbugs.gnu.org id=B59805.167034392121080 (code B ref 59805); Tue, 06 Dec 2022 16:26:01 +0000 Original-Received: (at 59805) by debbugs.gnu.org; 6 Dec 2022 16:25:21 +0000 Original-Received: from localhost ([127.0.0.1]:43823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2aky-0005Tw-KT for submit@debbugs.gnu.org; Tue, 06 Dec 2022 11:25:21 -0500 Original-Received: from mail-zr0che01on2045.outbound.protection.outlook.com ([40.107.24.45]:38816 helo=CHE01-ZR0-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2aku-0005Tl-Qn for 59805@debbugs.gnu.org; Tue, 06 Dec 2022 11:25:18 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RvaX6kpUnNbXL1663EZS/k33uaqblOn0CD/sDj3RwbJ+5Ol7WNqLfMKzP2nZcLPVivQuF24szF9Zif96qlEYI3YUYVk1hI0tyyMS8BC2o8+jmUI6woUWWprvH+HjinoOaPdjhDc4NqQE8tthPFmi2GlB/ls4BmJ1rs/u2BgxIus6Z6xMuyoiETPJ2PD4Ww/I4HMoePJbMtPd+l6m1eMZxENoU9i4WbQYkJWOMxxXlHJaY1eqZN7Uv1cW6xyyny7QQdh3i5+YpRkIiKWqQK/tO30958Ad6y5LgKjnxkW2MBgJqsbom9BMihubTzEvioWofiQkcgibfJa/7DLbSIKWCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rbVvRYh1nfRSTR3iw+rNhxPl1JDk68mR3BsQbukGX+U=; b=awUURmISX2u2hmk1VhjMiPzNgKUAh0KVuiqYP6bBt4PH/jmUwulQvZqhmu1QKPHA29O9RLUawDScu/QqsGZX1t+OMASOZXvx1+Mmxhd6okGjCWLjbo/SfJ/lAS64uAWtHD1RBm2gz9Go2JKrXSaOn4IDx9QkuoJuS7dX6vqekaLQx2tVEk55T5zFDZyzGWON9uUrZiGmYCZ9GKXqEtAQgxDyTKD5rjKN3iocHCbc3ItAIcK9PFq1Zc6oFw6UDuHSCpz1QYTv6YpVl6aQelVyoTdFlYLOr+0kFKNK0+FHThu72LbNaWJaUB96aGmZEpjybfq9e0P1WsGsrH2yuvVRxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cern.ch; dmarc=pass action=none header.from=cern.ch; dkim=pass header.d=cern.ch; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cern.ch; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rbVvRYh1nfRSTR3iw+rNhxPl1JDk68mR3BsQbukGX+U=; b=nMbo2qyGdcV5I2hYvsJbnx7OCoZ3j3VEymUiky53/xPW3afHomSOcKgy+5W4WLlff6NI77zQuIQAYsge1spjnBBJv29Il/75PJu6K45rEkt7JT0BExakjpOJnZPF/c1itci8LULoeMnHlQVV4v8uCJGYcOHFT1EHRRQJRsHxYZY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cern.ch; Original-Received: from ZR0P278MB0457.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:30::14) by GVAP278MB0795.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:57::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 16:25:10 +0000 Original-Received: from ZR0P278MB0457.CHEP278.PROD.OUTLOOK.COM ([fe80::d3b6:e709:9c1c:d05b]) by ZR0P278MB0457.CHEP278.PROD.OUTLOOK.COM ([fe80::d3b6:e709:9c1c:d05b%6]) with mapi id 15.20.5880.013; Tue, 6 Dec 2022 16:25:10 +0000 In-reply-to: <87bkoglilv.fsf@neverwas.me> X-ClientProxiedBy: ZR0P278CA0105.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::20) To ZR0P278MB0457.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:30::14) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR0P278MB0457:EE_|GVAP278MB0795:EE_ X-MS-Office365-Filtering-Correlation-Id: f25fbbec-4b66-42c2-735a-08dad7a671c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e9Ee2IkbOhSEbb3mRFfyjxPGRvoi0Pu01d/5+ZmxXP0mM4dg75FF2HilqGn8Dj3CcuUSOxO0jeleVsf74j0Q6mCyJyQvFSNtz54JqpLq5uXk/AiBWmTMkwDPthi+BOLMfYDOYPI1Q/qxGb11uM4BOqZNjnP5t9hreszRjaYYU47rGGhst3u0oSNFI5M8rZPNibCccEhutz0GxB1sH+iN622c7xJwmWL+C9rkOmbY3NViq+dCr+f34mDdfjkSdhEgEaeHfws9XmACKON1ydTvvpWZONr9ocxPtylRHnMHFGuSDC42/JMa+7s4QtnZbhJ2MYkDQfJKJmljfTkDK/FEPB3ns1ric0WbaWfezxLNBz8bKp2exL5PButBrEvie1Y19KbRwekZJ5HM0y4S4p6eyHHRJ+TmXeu3nrgqAS/HUBFHvv4RiPyGl2V1j2ukDMnFeKILWww8IgiJYNyK0eGxFq5zvifEKJWgrt6X783p5Ohuq9pemTV1lFsTSUS5B32fS7S21ck6xbkWNllv5g+qpp0yWES4U1Vp1toQ9H12Ae3rirqtM/uX8owU8IPVoNSS/Mb18xBD9Kz2d2kRFUPrF3OIDUUtJn2/+nQHczUnZfB1HI3CRufsppzC1pFqMHLXS74EppNC0PFWCtYlKErCRRrWrrtCOsYocM7oiA1+ZbKXU9Aep9haDgRZIoYFHDAQ600XwAnhV4kaRds5/vwEAw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:ZR0P278MB0457.CHEP278.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199015)(66899015)(36756003)(8676002)(38100700002)(5660300002)(86362001)(8936002)(41300700001)(2906002)(4326008)(44832011)(66476007)(66556008)(478600001)(966005)(6486002)(66946007)(2616005)(6916009)(316002)(41320700001)(786003)(6506007)(186003)(6512007)(41080700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: chFBBnVFBgXUDo0pQ+bCSVjt6xk/vnx2CLAwavcj95gXFxKV6n8KWFl7+SnX/FiI9792RgTaDMM5+/C4getSsC1dqsTNx2JExPwQIc5UU2N7p9wy2MpgHZEZOXZOUsALjDmaGmySwy5YEZDGRVHWNyq2rHNmVnLVbPus8l9LwULgvSUWQicigjsICs6JTlBAN2AeSDXYlQ23wn/lyiZ7c5xMZ2z52SrbO9U0TJdNL8ofGgjLrRvKfO6624xMspK7JyHKnqzlF/cUIo+5wsz6oeiqcCCzmR4/DiIUfb4AzLfDSKAmLjVwnuHihcx+SquvMHONzVZyTs5NQ6Nsy0hFJ5eJA80nfMnnP2QCkPijzBMW/9KgKrgH5gO1FZ9WYH3vW5n3g0LXHvtkgTiRuCOEHkYNYLMW6qr2jSxBw1UguFj0anZHSTiLhYhshClTOG9mvmRfdHSIRT6X9OUMSPDtm2VYJ/Ew6x9GZcOswTvC1ycW987KJ37uzLA15kwdLYq80RCDim/fqssnqQa8eLUGJ+Wtt6IcC1pDNZzC1kt+kuAeWrmlraqNYd9sEuA3IYOowqwa7exhdnPrWzacyglCCbT9I928ku1JdR04f2baqcKZXFcDt+q+6a6NUrc0aN8ahafPMyqLZ2xOJjDJQbdjNLY6ILK47yBNQ+uAt22dbVJk5ozizrriXFnp81HJL8gYVWX8CwRZOFsWGxJiv6HP0HmOjrd0xVcKuU+VCCDy49x8MK14PuMJAIFzqp Qkl+lt5SMKmBzSnKp92SiHq7TIAQroFusWyjtGAwiq/RGeplynUgiGT0T0Q8mnAmQ99/8Fxf6Bzryj8kfCUfYILwaK0/zm+jdi X-OriginatorOrg: cern.ch X-MS-Exchange-CrossTenant-Network-Message-Id: f25fbbec-4b66-42c2-735a-08dad7a671c3 X-MS-Exchange-CrossTenant-AuthSource: ZR0P278MB0457.CHEP278.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 16:25:10.0516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c80d3499-4a40-4a8c-986e-abce017d6b19 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DLUmPmtBiKFyoMCYicgtXcc4YQ/wajWr/Vt2Gabnzsj/EfWrtVWWxz4UtxpOOXGig4Sqq9QFKLo3zGSIjtaGbQWhoWFBVe3djcSLO540uNw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0795 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250128 gmane.emacs.erc.general:2021 Archived-At: Hi J.P., On 06/12/22, J.P. said: > Thanks for submitting this proposal. I have yet to form any opinions > about it but promise to eventually. In the meantime, I'll mention some > broadly related observations I happened to make while looking at it > briefly. Some are likely of less interest to you, but I'll state them > here anyway for lack of a better venue. Thanks for taking the time to do this; your insights have been useful for me to learn new stuff. As I mentioned I'm rather unfamiliar with ERC's code *grins*. > Looks like the default value of `erc-track-faces-priority-list' contains > some composite faces, such as > > (erc-nick-default-face erc-current-nick-face) > > So whatever happens, I think we'll have to preserve compatibility for > people already used to searching for such composites. I was totally unaware that "face composites" were a thing, so perhaps my proposal to flatten the return value of `erc-faces-in' does not make sense anymore. > In fact, have you tried adding > > (erc-hl-nicks-nick-nacho-face erc-current-nick-face) > > to `erc-track-faces-priority-list' while also overriding the function > `erc-hl-nicks-face-name' with something like this? > > (lambda (nick) (intern (concat "erc-hl-nicks-nick-" nick "-face"))) > > If that shows any promise, it could probably only ever manifest as a > user option for a select subset of declared nicks, so as not to inundate > the global obarray with ERC spam. This is indeed what I did initially in my configuration, before I thought about reporting this bug. This approach works, however in my opinion it's not ideal (for me as user), because: 1) I have to monkeypatch erc-hl-nicks. 2) I have to hardcode the nick-dependant face name to look for. There's already a face to identify mentions to the current nick (`erc-current-nick-face') so this should not be necessary. 1) could be addressed by submitting a patch for erc-hl-nicks so those symbols are interned so they could be `equal''ed, as you suggested. For 2) I don't have an elegant/generic solution to propose, but adding (erc-hl-nicks-nick-nacho-face erc-current-nick-face) to `erc-track-faces-priority-list' can definitely work for me. My nickname is stable across networks, however I think that the rather valid use case of being notified no matter what your nick name is cannot be honoured elegantly when using erc-hl-nicks. -- bye Nacho http://cern.ch/nacho