From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 b8d2ec920f: Revert "Improve last change to xfaces.c" (05ece1eb8b) Date: Mon, 12 Dec 2022 10:48:59 +0800 Message-ID: <87359ljq04.fsf@yahoo.com> References: <167080778504.14972.16819452979975432761@vcs2.savannah.gnu.org> <20221212011625.58E8AC004B4@vcs2.savannah.gnu.org> <877cyxjqd8.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25056"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gregory Heytings To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 12 03:49:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4Yt2-0006PE-Lv for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Dec 2022 03:49:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4YsW-0000SE-5a; Sun, 11 Dec 2022 21:49:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4YsV-0000Rz-6R for emacs-devel@gnu.org; Sun, 11 Dec 2022 21:49:15 -0500 Original-Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4YsT-0001qh-A5 for emacs-devel@gnu.org; Sun, 11 Dec 2022 21:49:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670813349; bh=UkXNssqiqtUg1xOvt42V5RUGHjq7EjWFMNb1n6ff24k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=C95j2QfEooeRBBayx1ckgF0fdUtAiVRXLgTddozLY78tPOj9UOM6ov1iw+hl+xaplKidKyg0UOKoqgIpCeSyWkbTQoCjJV50rGibIFP93VEmMZUMSOhNC6+oPpn4YBNdosGL1uRi976hhjc9SKPI8ElsD5kZlPrVbFaUoUDWxzW7nZJUcB4lrTXxEdg63YITzj+m2UEu1GjL7AOkAbEg3wTUWwsKQi8cxglSPwaTa39B01pvPFbwD4l/XOJ549yKKYfCcQA7WGULYd6qh0B2ht31LcxBXoRRG/z8mP6lRd/pX6HVDjhrrHrQE9p901yljdqmmSozJlAPRr+xCZh2UA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670813349; bh=3PRQf0ZuhdVnPmLezbx6TDUuuSCaXYaYY7YagNfaFlb=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hNUWD+Wx4/PN9HTCvgckxCExrZuUzEs+uYGmDUTqq0dXEJ7eO9RCVYv/XOLhHpYAjgH1hIc5fTfUwb756XTBWWTngfGN23GtoKEqPmAnEncwJq377DAWWwt/J7hTE0SOLtkOaBAzJalheaCZ64PUqRZsz88WRi7tBYppF9ISkcleOYUiQkqXO7j7QHvh/w6hTNISk61kiVJUjQbjaFT4flxs7XT8Ko2saLfIYBKaf9x1G9WxjD4oRfiysHVR/tyNID1Z3Ae+dQ6yengpc6fyS8ZpJkh2hc75TXcNRTbafLn3tpYo33VQ2NRbGgvQH3T4Dz+jJnzIg17eEYDGlK3aUw== X-YMail-OSG: Y9aLbHUVM1kPj2AspLKHl4FHTPdvO7aelvpUMFCfKZjR025v7oP_ebBZrGyMzZQ iycb7t8HDxJ_tDI.KQqggWG1ZT8w_1YyDtSuzMYO7j0qAbAzHIOEzRv5nvBtjR4fXu0RKFRaeAqy vNZc71LjcTMtVP6nVm.h8Z4VuNVdzvvWcGVSIq2QxUyUKwddhQ3hvQAiB36BU4BCSv9xZ2Ji6Na2 jb6v31yBepkQXqRdqyRlhiQp_HR06RIFr4sbN_8mljaZBgLISptcKLm.FnwqCtqloTwxDnUv3ExA RePswVcxJXtPfd2AYwlTVaTJiYh_VodmNorxECVN.QKD39U8r.OFC_T7R_Zhl2or9tpqZyCEyDgx 9gEGaASOMme0ZHoKXDAQUJnKdYydaPn_o.v5Y_2NBiDzXBACSPCx2MscUL.dTUlOlaWq8d0CpBKU 2EWcbw4QQbMd_tIVnSb5USIZX0_MRd4d5oj61c0Cra2e8HoQBTJ0XNpzFWuGuOwZ7NtxKmBemXSH 7tvOHKvhRZZrUf13fsud_R.F5GVT3SD_FTFWDCU2c8gMbYyAVQbQDQyOzECwlJoR4KvBBPjF2V6B 4LY_jkuAvLdB2eqALK86osFCk9DtnfXlCZFo9TDFUxPjziwdABmUB3tqsTrDiat9lUEuhQL9dACc Ug9RfmHb3rszUFT2ogfLnzMQ2DE47v.gimIwfhGdgeJfzewVSr.pSAu9.vi_1Rbl_liTfHFjCVZy Xf8W29Cwgg4b9d7M8Jn5woM7IopUmy8zk08zzG2321KxmuMfm2yEkPZF8O7dmIAH0dSkiOgtA4V0 .n_NLhTIgIz8I.l2rwkZarUd55kQwDPLSeR4x75zuh X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Mon, 12 Dec 2022 02:49:09 +0000 Original-Received: by hermes--production-sg3-b666c6484-4bg7k (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7359fddca6f63a59536b4a3506886c36; Mon, 12 Dec 2022 02:49:04 +0000 (UTC) In-Reply-To: <877cyxjqd8.fsf@yahoo.com> (Po Lu's message of "Mon, 12 Dec 2022 10:41:07 +0800") X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.199; envelope-from=luangruo@yahoo.com; helo=sonic301-30.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301184 Archived-At: Po Lu writes: > Gregory Heytings writes: > >> branch: emacs-29 >> commit b8d2ec920f37f5d77d32440eefc97dd5e8c2c7dc >> Author: Gregory Heytings >> Commit: Gregory Heytings >> >> Revert "Improve last change to xfaces.c" (05ece1eb8b) >> >> * src/xfaces.c: Revert 05ece1eb8b. >> >> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59347#331. > > Don't do that! You did not answer ANY part of what I said. Btw, for posterity's sake, I undid this revert for two reasons: - unsetting the "extra" attribute is not safe on the Haiku port. - the bitmask variable is a real nusiance for anyone trying to debug Emacs or change the layout of the font attribute index enumerator. Just because a bug has been closed does NOT mean the change in it is no longer subject to scrutiny. I don't follow bug reports that aren't related to X, which means I (and possibly many others) only see changes as they arrive on emacs-diffs. Which means that by the time the bug is closed, no, the discussion is not ``over'', and other people still have a chance to make changes to problems they see as they see them (a bitmask depending on the internal layout of an enum exposed to Lisp is definitely one such problem, so is unsetting `:extra'.)