From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#60333: [PATCH] whitespace: Update bob, eob markers in base and indirect buffers Date: Wed, 28 Dec 2022 13:48:46 +0000 Message-ID: <87358zprk1.fsf@localhost> References: <87k02dz75f.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19852"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60333@debbugs.gnu.org, Richard Hansen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 28 14:50:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAWp7-0004ws-MB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Dec 2022 14:50:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAWoo-0006gk-Bn; Wed, 28 Dec 2022 08:50:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAWol-0006gY-FA for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 08:50:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAWok-0006Yn-PW for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 08:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAWok-00034K-7S for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 08:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Dec 2022 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60333-submit@debbugs.gnu.org id=B60333.167223534811717 (code B ref 60333); Wed, 28 Dec 2022 13:50:02 +0000 Original-Received: (at 60333) by debbugs.gnu.org; 28 Dec 2022 13:49:08 +0000 Original-Received: from localhost ([127.0.0.1]:57278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAWnr-00032u-DZ for submit@debbugs.gnu.org; Wed, 28 Dec 2022 08:49:07 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:50001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAWno-00032O-Uy for 60333@debbugs.gnu.org; Wed, 28 Dec 2022 08:49:05 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0331A2402A2 for <60333@debbugs.gnu.org>; Wed, 28 Dec 2022 14:48:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672235339; bh=rsT/FYzT0FMqHiUZNiAcR7uA+7MbukOEKCCQXLUvErE=; h=From:To:Cc:Subject:Date:From; b=d59eV4lPDAkYh635uK5hfOB1ULbvMHltGReVq85TA9m77vuPzMTSCRs89a+sMRpSK GPn0Rn57Yo74sHlsFo/ej5dnA6t4HTXQABns6nBSgRpG1bR+hyszuafoOfQz1xQ+Ad ++2DXeY8E0msY1Hm8Su+lLpVMF08OxKPqbUX36EMo2JM3KQkMkTy05kseYXYPsPNna /kM7ehX9aUt+6xMw5jC7VGCaKyIfN01AwMGKBlzAcKpS7NVs+0qhe/VPWa1CFTO1xk n/WEYPqgoaCzWRxu/fSyYVx6mHjBGbLWwRbIMfKOpZeV8+lfhYPcNvE6vupKeu0rj2 8rHHo10DDxnyA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NhtCq5Tzzz9rxD; Wed, 28 Dec 2022 14:48:55 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251984 Archived-At: Stefan Monnier writes: >>> +(defvar whitespace--indirect-buffers nil >>> + "Plist mapping a base buffer to a list of its indirect buffers. >>> +Used to work around Bug#46982.") >> Org uses a similar variable for similar purposes. >> Would it make more sense to expose the list of indirect buffers for a >> given buffer in more centralized way? > > "Expose" is the wrong term, because we don't have that info ready to > be exposed. We'd either have to create&maintain that list, or compute > it on-demand when requested. > > We could export some way for ELisp to check if BUFFER is the base buffer > of some other indirect buffers so as to skip the loop through > `buffer-list` in the common case. So that sane code (i.e. code which > doesn't use indirect buffers) doesn't pay for the careless users of that > anti-feature :-) > > If it weren't for backward compatibility, I'd suggest to make > `buffer-base-buffer` return t (rather than nil) when BUFFER is the base > buffer of other indirect buffers. What about: 1. Maintain internal indirect buffer list associated with buffers in C 2. Every time an indirect buffer is created, add the new buffer to that list 3. Add a new function `buffer-indirect-buffers' that will return the list of indirect buffers associated with the current buffer. The function will do something like: (unless (buffer-base-buffer buf) (let (result) (dolist (indirect BUFFER_INDIRECT(buf)) (when (buffer-live-p indirect) (push indirect result))) BUFFER_INDIRECT(buf) = result result)) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at