From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60623: 30.0.50; Add forward-sentence with tree sitter support Date: Sun, 08 Jan 2023 21:07:21 +0100 Message-ID: <87358ku6x2.fsf@thornhill.no> References: <87o7ratva2.fsf@thornhill.no> <87bkn9tasb.fsf@thornhill.no> <83sfgloz5w.fsf@gnu.org> <875ydgu8dd.fsf@thornhill.no> <83fsckpznk.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60623@debbugs.gnu.org, juri@linkov.net, casouri@gmail.com, monnier@iro.umontreal.ca, mardani29@yahoo.es To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 21:08:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEbxo-0004mo-AF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 21:08:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEbxc-0005lE-60; Sun, 08 Jan 2023 15:08:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEbxa-0005ks-HH for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 15:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEbxa-0000ll-7s for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 15:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEbxa-0007Kg-07 for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 15:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60623 X-GNU-PR-Package: emacs Original-Received: via spool by 60623-submit@debbugs.gnu.org id=B60623.167320844728141 (code B ref 60623); Sun, 08 Jan 2023 20:08:01 +0000 Original-Received: (at 60623) by debbugs.gnu.org; 8 Jan 2023 20:07:27 +0000 Original-Received: from localhost ([127.0.0.1]:34772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEbx0-0007Jp-PT for submit@debbugs.gnu.org; Sun, 08 Jan 2023 15:07:27 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:63131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEbwy-0007Je-QN for 60623@debbugs.gnu.org; Sun, 08 Jan 2023 15:07:25 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1673208443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hyVUoVeNl2CiFkNTtxSI2gAQvtTGG0bYgdyQnFHeL1U=; b=waJuhcnjpuLKPqgbkQw+Binq608FLK/dwDJkygpfPsMPRA30ajI4cVqNsPQnAdfSQ6ToEi scaigT8CdZuB7Vm41gRpwAMsjBKQIA+BznGwhygDNIAyK4r1jjUE7zis8Svy//rytGknDu P1XbjhCDQ2wBYpUVcHI+F9Td3ogUteGEUwM4grqQZc6Yhgu3w1vlFMIDNzcjFCEZ4j72We dzOVDMyqNb3aig/AsnP+5pwmHWR7Y8JzsCr4PMx/x2GtckbZGO8NBeEw8w9ULx8IAif+3z l9jaEgPfzYmkPjMwGcXjHWof2b5VSy9ALNCyDwLh7r7w25tPop8+Mh2OeRz1Pw== In-Reply-To: <83fsckpznk.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252959 Archived-At: Eli Zaretskii writes: >> From: Theodor Thornhill >> Cc: mardani29@yahoo.es, bug-gnu-emacs@gnu.org, 60623@debbugs.gnu.org, >> casouri@gmail.com, monnier@iro.umontreal.ca, juri@linkov.net >> Date: Sun, 08 Jan 2023 20:35:58 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Theodor Thornhill >> >> Cc: 60623@debbugs.gnu.org, casouri@gmail.com, eliz@gnu.org, >> >> monnier@iro.umontreal.ca,Juri Linkov >> >> Date: Sun, 08 Jan 2023 14:29:08 +0100 >> >> >> >> @Eli, what doc changes do you see as needed here? >> > >> > More or less. They need some polishing, like a few words about what >> > does "sentence" mean in the tree-sitter context. But we can make >> > these changes after this is in the repository. >> > >> > Thanks. >> >> >> Ok, so in other words, this patch is good to go? > > Yes, I think so. > Great! >> I omitted the additions to java-ts-mode and c-ts-mode. I can make a >> separate commit to add some values that makes sense for multiple modes >> after? > > SGTM. > Nice. Will you install this for me? >> Will the changes to the manual lie in "26.2 Sentences"? in the Emacs >> manual? > > No, because these are not really sentences in some human-readable > language, these are program parts. As such they should be somewhere > under "27 Programs", possibly in "Defuns". > > However, "Sentences" might mention that programming modes have their > own interpretation of "sentence" and corresponding movement commands. Yeah, that makes sense. Should I make an attempt at such formulations, or will you do it at a later time? Theo