[PATCH] lisp-mode: add docstring recognition for more common lisp symbols

[PATCH] lisp-mode: add docstring recognition for more common lisp symbols

[Nicolas Martyanoff]

Add the 'doc-string-elt property to deftype, define-setf-expander and and
define-compiler-macro for proper docstring highlighting in Common Lisp.
---
 lisp/emacs-lisp/lisp-mode.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 367f59e8785..d44c9d6e23d 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -181,8 +181,11 @@ lisp-mode-autoload-regexp
 (put 'define-category 'doc-string-elt 2)
 ;; CL
 (put 'defconstant 'doc-string-elt 3)
+(put 'define-compiler-macro 'doc-string-elt 3)
+(put 'define-setf-expander 'doc-string-elt 3)
 (put 'defparameter 'doc-string-elt 3)
 (put 'defstruct 'doc-string-elt 2)
+(put 'deftype 'doc-string-elt 3)
 
 (defvar lisp-doc-string-elt-property 'doc-string-elt
   "The symbol property that holds the docstring position info.")
-- 
2.39.1

Re: [PATCH] lisp-mode: add docstring recognition for more common lisp symbols

[Eli Zaretskii]

> From: Nicolas Martyanoff <nicolas@n16f.net>
> Cc: Nicolas Martyanoff <nicolas@n16f.net>
> Date: Thu,  9 Feb 2023 11:39:14 +0100
> 
> Add the 'doc-string-elt property to deftype, define-setf-expander and and
> define-compiler-macro for proper docstring highlighting in Common Lisp.

Thanks, installed on the emacs-29 branch.

Please in the future try to follow our style for log messages more
closely.  As an example, look at how I modified your log message for
this commit.

Re: [PATCH] lisp-mode: add docstring recognition for more common lisp symbols

[Nicolas Martyanoff]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Nicolas Martyanoff <nicolas@n16f.net>
>> Cc: Nicolas Martyanoff <nicolas@n16f.net>
>> Date: Thu,  9 Feb 2023 11:39:14 +0100
>> 
>> Add the 'doc-string-elt property to deftype, define-setf-expander and and
>> define-compiler-macro for proper docstring highlighting in Common Lisp.
>
> Thanks, installed on the emacs-29 branch.
>
> Please in the future try to follow our style for log messages more
> closely.  As an example, look at how I modified your log message for
> this commit.

Ah you mean like some kind of file-by-file changelog? No problem.

Thank you for merging the patch!

Regards,

-- 
Nicolas Martyanoff
https://n16f.net
nicolas@n16f.net

Re: [PATCH] lisp-mode: add docstring recognition for more common lisp symbols

[Eli Zaretskii]

> From: Nicolas Martyanoff <nicolas@n16f.net>
> Cc: Nicolas Martyanoff <nicolas@n16f.net>,  emacs-devel@gnu.org
> Date: Thu, 09 Feb 2023 15:47:45 +0100
> 
> > Please in the future try to follow our style for log messages more
> > closely.  As an example, look at how I modified your log message for
> > this commit.
> 
> Ah you mean like some kind of file-by-file changelog? No problem.

Yes, we use ChangeLog-style log messages.  Of course, in addition to
the file names and function names, you can provide any supporting
free-style description of the changes, their reasons, and whatever
else you think is important.  But we want the file and function names
to be also present.

Thanks.