[PATCH] Fix one remaining emacs-30 byte-compile warning

[PATCH] Fix one remaining emacs-30 byte-compile warning

[Arash Esbati]

Hi all,

Robert sent a patch[1] which pacifies emacs-30 compiler warning.  He
missed one which is fixed by the patch below.  It is against org-mode
master (6b15897a56).

Footnotes:
[1]  https://lists.gnu.org/archive/html/emacs-orgmode/2023-01/msg00743.html

Best, Arash

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
 Optional argument POST-PROCESS is a function which should accept
 no argument.  It is always called within the current process,
 from BUFFER, with point at its beginning.  Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,

   (defun org-latex-export-as-latex
     (&optional async subtreep visible-only body-only ext-plist)
     (interactive)
     (org-export-to-buffer \\='latex \"*Org LATEX Export*\"
       async subtreep visible-only body-only ext-plist
-      #'LaTeX-mode))
+      #\\='LaTeX-mode))

 When expressed as an anonymous function, using `lambda',
 POST-PROCESS needs to be quoted.
--8<---------------cut here---------------end--------------->8---

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Ihor Radchenko]

Arash Esbati <arash@gnu.org> writes:

> Robert sent a patch[1] which pacifies emacs-30 compiler warning.  He
> missed one which is fixed by the patch below.  It is against org-mode
> master (6b15897a56).

Thanks!
Could you please write a full patch with commit message? See
https://orgmode.org/worg/org-contribute.html#first-patch

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Robert Pluim]

>>>>> On Tue, 24 Jan 2023 10:29:17 +0100, Arash Esbati <arash@gnu.org> said:

    Arash> Hi all,
    Arash> Robert sent a patch[1] which pacifies emacs-30 compiler warning.  He
    Arash> missed one which is fixed by the patch below.  It is against org-mode
    Arash> master (6b15897a56).

I didnʼt miss it, it was next on my list, since I didnʼt want to mix
different types of fixes in the same commit. Of course my fixes are
incomplete, as Ihor has pointed out, so more work is needed there. 😀

    Arash> +use it to set a major mode there, e.g.,

I prefer ':' to ',' in such situations, but I donʼt recall what the
official position is (if there is one).

Robert
-- 

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Ihor Radchenko <yantar92@posteo.net> writes:

> Could you please write a full patch with commit message? See
> https://orgmode.org/worg/org-contribute.html#first-patch

Thanks for your response.  I hope I've got it right.

Best, Arash

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-ox.el-Pacify-compiler-warning.patch --]
[-- Type: text/x-patch, Size: 1200 bytes --]

From c550ed05d29cf163c286cffc328e5860423c7cde Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Wed, 25 Jan 2023 16:34:42 +0100
Subject: [PATCH] lisp/ox.el: Pacify compiler warning

* lisp/ox.el (org-export-to-buffer): Escape single quote in the
example given in docstring.
Add missing '.' after the abbreviation.
---
 lisp/ox.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
 Optional argument POST-PROCESS is a function which should accept
 no argument.  It is always called within the current process,
 from BUFFER, with point at its beginning.  Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,
 
   (defun org-latex-export-as-latex
     (&optional async subtreep visible-only body-only ext-plist)
     (interactive)
     (org-export-to-buffer \\='latex \"*Org LATEX Export*\"
       async subtreep visible-only body-only ext-plist
-      #'LaTeX-mode))
+      #\\='LaTeX-mode))
 
 When expressed as an anonymous function, using `lambda',
 POST-PROCESS needs to be quoted.
-- 
2.39.1

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Arash Esbati]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Tue, 24 Jan 2023 10:29:17 +0100, Arash Esbati <arash@gnu.org> said:
>
> I didnʼt miss it, it was next on my list,

Sorry for my wrong assumption here.

> Of course my fixes are incomplete, as Ihor has pointed out, so more
> work is needed there. 😀

I know why I volunteered for the change I suggested 😉

>     Arash> +use it to set a major mode there, e.g.,
>
> I prefer ':' to ',' in such situations, but I donʼt recall what the
> official position is (if there is one).

-> git --no-pager grep "e.g.:$" | wc -l
13

-> git --no-pager grep "e.g.,$" | wc -l
49

':' would have been my preference my well.

Best, Arash

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Ihor Radchenko]

Arash Esbati <arash@gnu.org> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Could you please write a full patch with commit message? See
>> https://orgmode.org/worg/org-contribute.html#first-patch
>
> Thanks for your response.  I hope I've got it right.

Thanks!
Applied, onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=65ca7bc6a

You are also now listed as a contributor.
https://git.sr.ht/~bzg/worg/commit/36cbf082

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Arash Esbati]

Ihor Radchenko <yantar92@posteo.net> writes:

> Thanks!
> Applied, onto bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=65ca7bc6a

Thanks!

> You are also now listed as a contributor.
> https://git.sr.ht/~bzg/worg/commit/36cbf082

Thanks for adding me.  You have me now under this section:

  * Current contributors with tiny changes

  These people have submitted tiny change patches that made it into Org
  without FSF papers.  When they submit more, we need to get papers
  eventually.

I have signed the FSF paper for GNU Emacs.  I'm not familiar with Org
development, but maybe you want to put me under, if at all:

  Here is the list of people who signed the papers with the Free Software
  Foundation and can now freely submit code to Org files that are included
  within GNU Emacs:

Best, Arash

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Ihor Radchenko]

Arash Esbati <arash@gnu.org> writes:

> I have signed the FSF paper for GNU Emacs.  I'm not familiar with Org
> development, but maybe you want to put me under, if at all:
>
>   Here is the list of people who signed the papers with the Free Software
>   Foundation and can now freely submit code to Org files that are included
>   within GNU Emacs:

Sure, but we need to confirm with FSF records first.
Bastien, may you take a look?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> Sure, but we need to confirm with FSF records first.
> Bastien, may you take a look?

Yes, I confirm Arash records are okay, sorry for the delay.

-- 
 Bastien Guerry

Re: [PATCH] Fix one remaining emacs-30 byte-compile warning

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Sure, but we need to confirm with FSF records first.
>> Bastien, may you take a look?
>
> Yes, I confirm Arash records are okay, sorry for the delay.

Updated WORG page.
https://git.sr.ht/~bzg/worg/commit/bf040f8a

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>