From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#62116: RFE: eglot: support window.showDocument LSP RPC Date: Sun, 14 May 2023 21:02:02 +0200 Message-ID: <87353y91p1.fsf@betli.tmit.bme.hu> References: <87jzznxx8f.fsf@gmail.com> <83fsabwhpg.fsf@gnu.org> <87v8j7vy48.fsf@gmail.com> <83r0tuv62t.fsf@gnu.org> <874jp8gu8a.fsf@betli.tmit.bme.hu> <838re3jowg.fsf@gnu.org> <87ttwqsow9.fsf@gmail.com> <87ttwpbpaj.fsf@betli.tmit.bme.hu> <875y93arek.fsf@betli.tmit.bme.hu> <87h6sla14k.fsf@betli.tmit.bme.hu> <871qjm5pzk.fsf@gmail.com> <877ctc8rc9.fsf@betli.tmit.bme.hu> <87wn1c4f65.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12631"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: sebastian.poeplau@mailbox.org, adonovan@google.com, 62116@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 14 21:03:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyH05-00035g-O7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 May 2023 21:03:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyGzo-0004EO-Cf; Sun, 14 May 2023 15:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyGzm-0004EF-Kp for bug-gnu-emacs@gnu.org; Sun, 14 May 2023 15:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyGzm-0003Tu-D6 for bug-gnu-emacs@gnu.org; Sun, 14 May 2023 15:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyGzl-0004BS-TR for bug-gnu-emacs@gnu.org; Sun, 14 May 2023 15:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 May 2023 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62116-submit@debbugs.gnu.org id=B62116.168409093516018 (code B ref 62116); Sun, 14 May 2023 19:03:01 +0000 Original-Received: (at 62116) by debbugs.gnu.org; 14 May 2023 19:02:15 +0000 Original-Received: from localhost ([127.0.0.1]:41576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyGz0-0004AI-Nc for submit@debbugs.gnu.org; Sun, 14 May 2023 15:02:15 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:57707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyGyx-0004A0-Mb for 62116@debbugs.gnu.org; Sun, 14 May 2023 15:02:13 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-3f4249b7badso80086045e9.3 for <62116@debbugs.gnu.org>; Sun, 14 May 2023 12:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684090924; x=1686682924; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Lh523KtBQvc+LRepxHoscHoDyQtrJ06/JeKm+z5IyRU=; b=Lx6SAUJCKesxJelVTuuShp3SM6nFdQrkhJdppfhiczkxtbmBhDS/46N/Cq/VXnK4+a 7gyQ1yzDG9H6LSJV7yqEys/gKfMOj2oAFcBZd3N1mMa6gb6oHYD/uogrSa5unmLWeB4X pAOy1CwBwTI61Bx1dolIKcfQ+uhg6JacTJWFY7EcfaReTuKfR7pF6tjuKmIqbka/+B5g 9p5pTL4X7SxYtP3cbeU2sMw2BnJGEC5nPr4dr8Wn07QQrWxEv4sezs9XRa3iTXHD/P5f sby3wB2hzeukKTWmD6nbyxfI4zaUqtpS9Y1XOld7wRQ9h7hKJ5e6UBvpSf+1Iek0sBqH quGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684090924; x=1686682924; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lh523KtBQvc+LRepxHoscHoDyQtrJ06/JeKm+z5IyRU=; b=ieR4zxg9YrGFmnAgUmFKj+e8jh+BZ2uFtn1JkVr7XWQ9n6A67tNUma7D1K7IvagO9j xC7XKpHvPF0jruwRQb4uyK1x19PiWmrjoBGzt9AODiOeiVWr3AoNgco2BCYZgqbrsQ1u 8aqSNB9bZuUfyvS/f+4yfXND8B7Hj9bqBv4lVH1ZBkCTvhdQgSE14/G7/ICM60RPfV6E dAKYAAE6/wpY9KPDxBDQDIBcM6sqjgMgW+c9+xRx1wlGsfnTFFpjC0oCRbwMxCrJ+TPv S2ovtkqqV3TEzY7iiKjg+Cg3+tuh09s4oY9sk3rhI5eUwfx0PiPf+g5Pvk7V9F1rY9Xa 8i7A== X-Gm-Message-State: AC+VfDzO+tV3b3yJ69Bbn0m9z99mCnQaZUao3cFWC53INnDjVLQXW3Cq UA412EkXwX2Y7Yu41IzE+J0= X-Google-Smtp-Source: ACHHUZ5ShiJdVAPRiaWPDKowEV2dWXVkVUs2BxeafQYtptEIjWIfXz0g7NeykeNow5MWGBuPariEMg== X-Received: by 2002:adf:fccb:0:b0:306:3899:ccbf with SMTP id f11-20020adffccb000000b003063899ccbfmr22658073wrs.14.1684090924396; Sun, 14 May 2023 12:02:04 -0700 (PDT) Original-Received: from betli.gmail.com (catv-89-134-210-182.catv.fixed.vodafone.hu. [89.134.210.182]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b002fe13ec49fasm29882978wrn.98.2023.05.14.12.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 May 2023 12:02:03 -0700 (PDT) In-Reply-To: <87wn1c4f65.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 13 May 2023 12:57:38 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261718 Archived-At: >> Even when takeFous is nil, shouldn't we still at least raise the frame? >> Otherwise Emacs might not show the document. > > I don't understand. Can you show this problem. , I think display-buffer > ensures the buffer is displayed. It doesn't guarantee that it is > visible in the context of the windowing system, but that's another > matter. I was worried about the case when there are two frames: frame A is in focus, and frame B is minimized but contains the target buffer. But you're right. display-buffer does raise frame B and keeps the focus in frame A. > I pushed a version with the above adjustments to master, as we're > converging anyway and it's easier than trading patches. The pushed version is good, but there is one minor problematic detail. It returns "success" even before it tries to find-file the requested URI. So if it cannot open the file, because the user does not have the required permissions, it is too late to send an error to the server.