all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Reindert-Jan Ekker <info@codesensei.nl>
Cc: "emacs-devel" <emacs-devel@gnu.org>
Subject: Re: bug#64023: 29.0.91; gnus-icalendar does not update timestamp when description is empty
Date: Tue, 13 Jun 2023 14:51:19 +0200	[thread overview]
Message-ID: <87352vh6ew.fsf_-_@gmail.com> (raw)
In-Reply-To: <m2mt134lsg.fsf@codesensei.nl> (Reindert-Jan Ekker's message of "Tue, 13 Jun 2023 13:57:35 +0200")

>>>>> On Tue, 13 Jun 2023 13:57:35 +0200, Reindert-Jan Ekker <info@codesensei.nl> said:
    Reindert-Jan> By the way, what is the intended behaviour of
    Reindert-Jan> gnus-icalendar--cancel-org-event? It seems to search for a property "DT"
    Reindert-Jan> that does not exist (at least in my files), so it does not change the
    Reindert-Jan> event. Is this a bug or am I missing some configuration somewhere?
    >> 
    >> It looks like a bug. I canʼt find any code creating such a property,
    >> the current code inserts the timestamp in the body of the org entry.
    >> 
    >> Robert

    Reindert-Jan> Do I need to send a new bug report for this?

It would be nice to have a separate bug so we can track the change.

    Reindert-Jan> I would also like to try and write the fix for this, if you don't mind.
    Reindert-Jan> I think the correct behaviour would be to completely remove the entry
    Reindert-Jan> from the file - probably with a confirmation prompt.

I never say no to other people writing patches 😺 Thereʼs lots of
useful info in CONTRIBUTE in the emacs sources about code and commit
message conventions.

    Reindert-Jan> Alternatively gnus-icalendar--update-org-event could update the entry to
    Reindert-Jan> include the word "cancelled" in the summary and deactivate the
    Reindert-Jan> timestamp.

Deactivating the timestamp is what the current code attempts to do, I
think thatʼs a less surprising change than removing the entry.

Robert
-- 



  parent reply	other threads:[~2023-06-13 12:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 15:48 bug#64023: 29.0.91; gnus-icalendar does not update timestamp when description is empty Reindert-Jan Ekker
2023-06-12 16:21 ` Robert Pluim
     [not found]   ` <m25y7sa6j0.fsf@codesensei.nl>
2023-06-13 10:48     ` Robert Pluim
2023-06-13 11:24       ` Eli Zaretskii
2023-06-13 12:45         ` Robert Pluim
     [not found]       ` <m2mt134lsg.fsf@codesensei.nl>
2023-06-13 12:51         ` Robert Pluim [this message]
2023-06-16 18:45       ` Reindert-Jan Ekker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87352vh6ew.fsf_-_@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=info@codesensei.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.