From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#59943: 30.0.50; ERC 5.5+: Add visual indicator to ERC keep-place Date: Thu, 13 Jul 2023 19:03:07 -0700 Message-ID: <87351rtfl0.fsf__35916.1808899202$1689300258$gmane$org@neverwas.me> References: <87fsdndzo1.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25734"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 59943@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 14 04:04:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK8AD-0006Q8-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jul 2023 04:04:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK8A8-0002q1-Bm; Thu, 13 Jul 2023 22:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK8A6-0002pd-Ft for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 22:04:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK8A6-0006oG-8C for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 22:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qK8A5-0000bF-QZ for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 22:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2023 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59943-submit@debbugs.gnu.org id=B59943.16893001982254 (code B ref 59943); Fri, 14 Jul 2023 02:04:01 +0000 Original-Received: (at 59943) by debbugs.gnu.org; 14 Jul 2023 02:03:18 +0000 Original-Received: from localhost ([127.0.0.1]:41082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK89N-0000aH-QV for submit@debbugs.gnu.org; Thu, 13 Jul 2023 22:03:18 -0400 Original-Received: from mail-108-mta111.mxroute.com ([136.175.108.111]:45223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK89L-0000a8-1S for 59943@debbugs.gnu.org; Thu, 13 Jul 2023 22:03:16 -0400 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta111.mxroute.com (ZoneMTA) with ESMTPSA id 189522348b20004cef.001 for <59943@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 14 Jul 2023 02:03:11 +0000 X-Zone-Loop: 33ceb0e8d262113abe4a7ef2b1df4cd0b6e06486e9f4 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gjPJ1zwu/Uo3+/+AnS582LhkuTrChuFHgitdh8Tup7U=; b=ZJXfylgiU7tpvGayOIHh+C7wGH juzeSMZZrQNQhaXPokOKSTiZ7K/CvNnihuzmTb456usyX9FTAZZycIxyXmrITg9nx9USJ2FVdpl1a E8Hw9MyT2o/MC3yr6B24yyNqSY+QDmuIXafB9ch/9knL+ee1SzoWNtNtzWbUyOwYFl2k0tUVRfrj1 1eWIw+t/Jmu79RJHa5Qu04taoeG0BmbiRpluQDz0wZSDYf41z7NlXGgQaWGjF4kZB6CxUhHs4q0yz 3Uw5Pk1qmiyiHal5p5CuRoe49MeiXX+SH/CVh76nVCxmRUIWY/2jo7JC1EqqDhb75gBdrCj+BLzbY 1iBwVokA==; In-Reply-To: <87fsdndzo1.fsf@neverwas.me> (J. P.'s message of "Sat, 10 Dec 2022 07:52:14 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265058 Archived-At: Reflecting back, I think the decision to tether this local module to the global module `keep-place' was wrong. A likely usage pattern for this feature is per-buffer activation, whether interactively or via join hook. Such users shouldn't be asked to buy into `keep-place' everywhere. Contrast this with `fill-wrap'. It too is a local module that depends on a global one, but there's no clear use case for *not* wanting it in some subset of buffers, so it's effectively global (but technically local for maintenance reasons). Anyway, I've gone ahead and fixed this problem [1], so that `keep-place' and `keep-place-indicator' are completely separate but work in tandem when `keep-place' is active. However, as implied, the local module can also operate completely independently. Thanks. P.S. Don't be confused by the version in the subject line: the original `keep-place' is new in ERC 5.6. [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2716dd13