From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 400df210ce0: Fix last change of 'delete-file' Date: Fri, 11 Aug 2023 13:41:01 +0200 Message-ID: <87350pu7qq.fsf@gmx.de> References: <169133064669.24990.11219399079845613336@vcs2.savannah.gnu.org> <20230806140407.09E6BC038BE@vcs2.savannah.gnu.org> <875y5n6nz2.fsf@gmail.com> <83o7jfhvw3.fsf@gnu.org> <871qgb6mg9.fsf@gmail.com> <83h6p7hueg.fsf@gnu.org> <87wmy355aa.fsf@gmail.com> <83cyzvhri7.fsf@gnu.org> <87msyyt4ne.fsf@gmx.de> <83h6p5hmex.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4974"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: rpluim@gmail.com, emacs-devel@gnu.org, esr@thyrsus.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 11 13:42:10 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUQWu-00016Q-Vg for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Aug 2023 13:42:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUQVy-0005PT-VR; Fri, 11 Aug 2023 07:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUQVx-0005PH-OL for emacs-devel@gnu.org; Fri, 11 Aug 2023 07:41:09 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUQVv-0005lZ-97; Fri, 11 Aug 2023 07:41:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691754062; x=1692358862; i=michael.albinus@gmx.de; bh=6RFRhtsIFESykmGHyaIuQpbPACaanqQfvzInLHp4Kvo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=BsQ7MD2DO4XqzBbXrYmFFQ0ZhqYRZEiM94ZQ1yfDHhPOMx+eBFgqSkjf3G3B4RyS0T8ZF9j nAjkYkHA/AsrlaU3WxFr90tMDp20ANa4wD3tFahvTG4Ri7C2jHGryDdMTGeerO9XeLjjwjZbY 0VsxN4Ig5AJrHeBCLjZmnb90+7d1WEhtyVbSHOVDKP0tvVxDKJdKzgzzxauvBwPLbD46TAuCr 2tD1LjrrC0wIvNOAd4pyFswL/SOSVkP/cXtxbN4aE886FWMBNnzuDQE7ITH79I2yYu75kT37l JMxYwwiFBosTnLmhfIbv61LNwJNbMp0xh/SvRFvqHNvfsTJvYnMw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiTt-1qN5qF0ZzR-00U6Yd; Fri, 11 Aug 2023 13:41:02 +0200 In-Reply-To: <83h6p5hmex.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2023 14:02:30 +0300") X-Provags-ID: V03:K1:XUFgKtQO46n+3Ad28LkWGpFc5RvBIJ93bPieDd1L6M2gmn7wPwJ KPbEbcu2UH4LVnpJlmDfpbBH5vWD1DoIdiTXMumSeoaLf/QxHYHzJW9GaXtTQ4xGY//eSGk QTukGmBs07dusSoQAcHpH/MgAJm6B0hJ5zD2Iac8NMSqDnvhnk4D1SSVsjrH4BqIejn/Jse L9WJZwd3vc/HNZGNNBE0A== UI-OutboundReport: notjunk:1;M01:P0:OnX5hZsDdgA=;Mngfi9Wvi4Ck4OHlE7B9IB+5IzG ZL+w/MbaZOkB0rhQPklEadk/dlS4ov58P68iCiOjMMOfa/w34ZePIYeDagx0RcJ0/4pIFHbdH 2rCy95M0m4YvpD24wYg3YjvT5AfXuF64uLNPi5/rdJkeJq2O+RrXYa2cs9IcXZG9Xi54Q9MKi 0wv+JbavlqV7I7ZsKFDCrKdL5SclecbIESpoChltR356zEE25i0vKIUx7IEPDJYjPTnzS9/sS ayYmP+QqiWD1TNukJPZuQj+zvBIsRtxwCy+bDYRja+YqZkNtAkWLU0S/GqQ02zjVKXDm7UJSP 66bYxJZPsk/aZszYdsI9GW02D1HFUruoTlw0hgRaCSOs6klCClwx0Tc2eYJKRL/Bm5m7M7Cu/ TCvx4IUHWk1KuYOO+hSrB4ZQAmXrC5F0rwWh8mWbX4e8NDG5G4mEGG99XMQXar3tCXeDz7zSV s5M64hjNqvppVexNasly9ynbz1C9UW+YSQzusVlBuoNVTSSP1FuGCrvmv/8TiLkKfA4rkN+wp RQhVzfGs0NMsnQm0eI7rxK61q8lt9NLpZyXS750EorCh4d4sOpNzqFEgcAVl7FrI1nWC0HneT 8JvJ74/qyw+rDFmnBkzzb1G7dTI4LTgBi/u/h/RKwqE47k8yxzi3FGp9xvWGH1W63N5hmjyqs Z+4tZWNVfsxv+hTWzSYhvk/YY8vu5LiLoHDUtVBnsRLjBLMNk+o0Ax2oyrpn4GJ8jLydG9f+v wI2VjovfRtHwUOjZcMUh3wyKcz9T+fxT5UMGhEev85lNwhKqLxfQ8f70zDAXZ23hTn2boN25 Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308572 Archived-At: Eli Zaretskii writes: Hi Eli, > Michael, this is my change, not Eric's. My question is above: is > there a requirement that file handlers are called with absolute file > names? If so, where is it documented, and why some places, which I > mentioned above, call file handlers with file names that were not > passed through expand-file-name? Ffind_file_name_handler calls fast_string_match (string, filename). STRING is the car of an entry in file-name-handler-alist, FILENAME is the file name to be checked. If the entry in file-name-handler-alist is a regexp for the head of an absolute file name, the check will fail when FILENAME is relative. >> > But the same would be true for substitute-in-file-name, for example, >> > and for directory-file-name, and file-name-as-directory, and several >> > other primitives, which call Ffind_file_name_handler without calling >> > expand-file-name before that. substitute-in-file-name, directory-file-name, file-name-as-directory and likely more primitives do not support relative file names like "123". They support file names relative to the remote, like "/ssh::123". Is this a bug? Don't know, nobody has protested so far. But at least it is undocumented. Other primitives handle this themselves if necessary. Fdelete_file and other function expand the file name. In Fexpand_file_name itself, we have --8<---------------cut here---------------start------------->8--- handler = Ffind_file_name_handler (name, Qexpand_file_name); ... handler = Ffind_file_name_handler (default_directory, Qexpand_file_name); --8<---------------cut here---------------end--------------->8--- I wouldn't touch this as it works. Improvements in documentation might be appreciated. Best regards, Michael.