From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Proposal for 'package-isolate' command Date: Thu, 17 Aug 2023 14:19:36 +0000 Message-ID: <87350hhhtz.fsf@posteo.net> References: <87r0oftgye.fsf@posteo.net> <87350vt1wz.fsf@posteo.net> <871qgen1ln.fsf@posteo.net> <87edke4mou.fsf@posteo.net> <87wmy6kuan.fsf@posteo.net> <87wmy6w070.fsf@posteo.net> <87zg2sjleg.fsf@posteo.net> <87pm3nlbm7.fsf@posteo.net> <87zg2ri9g9.fsf@posteo.net> <87bkf7b7ls.fsf@posteo.net> <87v8dfi6zy.fsf@posteo.net> <877cpvb361.fsf@posteo.net> <87pm3mj0ot.fsf_-_@posteo.net> <87v8de9qel.fsf@posteo.net> <87pm3mgj8d.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21474"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thierry Volpiatto , emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 17 16:20:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWdrD-0005Il-Lk for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Aug 2023 16:20:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWdqh-0002og-Sn; Thu, 17 Aug 2023 10:19:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWdqg-0002np-07 for emacs-devel@gnu.org; Thu, 17 Aug 2023 10:19:42 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWdqd-0003qB-Nm for emacs-devel@gnu.org; Thu, 17 Aug 2023 10:19:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 745EC240101 for ; Thu, 17 Aug 2023 16:19:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692281977; bh=K2ktUMyMCN0Kfy6nRFKl12lkap/cBrYK+BYgO2D8if4=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=fKNXaC0iEPSZXe+XqWNHg0qcRkbAvqV4qDFTS4KuCVXrDZlfcJH20hFv8vazJSosZ W0z4jn/BgpQGE2EGnSONcRUIyYwPdTmsRZUM1YyMhmfRTQRKM384mArldg96SVATst A2VlsLFJJSawRW7K+0wtMn2Ny6XOEe1FcV5dlMvk82IKXGnDWjunHfbOYaMep5d68s uBRFZimRShBKb+XUz3fbuLkTLiQLELXJcWy+ajKDOTP3PwnWlc9miHICkcZplxGbsC 2e/RlTvbFeLtD9sPrQeY6Oc5AzqByY1U6nSPocRNsN+rLwfF2Fc0eYVekjAfu85tBx hsfseIZYrVUNw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RRRw86LmJz9rxG; Thu, 17 Aug 2023 16:19:36 +0200 (CEST) In-Reply-To: (Eshel Yaron's message of "Thu, 17 Aug 2023 11:07:21 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308868 Archived-At: Eshel Yaron writes: > Hi Philip, > > Philip Kaludercic writes: > >> How about this patch, that will use a temporary directory when >> `package-isolate' is invoked with a prefix argument (not sure what the >> default should be, I guess reusing `user-emacs-directory' is less >> surprising): > > I'm again looking forward to trying this out, I think it could be > helpful for testing the Compat integration I'm working on for a package > of mine. I also again have a couple of minor suggestions around > documentation: > >> (defun package--dependencies (pkg) >> - "Return a list of all dependencies PKG has. >> -This is done recursively." >> - ;; Can we have circular dependencies? Assume "nope". >> - (when-let* ((desc (cadr (assq pkg package-archive-contents))) >> - (deps (mapcar #'car (package-desc-reqs desc)))) >> - (delete-dups (apply #'nconc deps (mapcar #'package--dependencies deps))))) >> + "Return a list of all recursive dependencies of PKG. > > I'd say "transitive" rather than "recursive" dependencies, because I > think a recursive dependency is more commonly used to refer to a case in > which a package (or library, etc.) depends on itself. I wouldn't say recursive but cyclical in that case, but either way I think transitive is a better word here. Will change it. >> +If PKG is a package descriptor, the return value will consist of >> +a list of package descriptors. If PKG is a symbol, designating a >> +package, the return value will be a list of symbols designating >> +packages." > > Personally, I find the future tense less clear than the present tense > when describing deterministic software behavior. So usually I prefer it > when the docs say what the program "does", not what it "will do". In > this case that be "if PKG is a package descriptor, the return value is a > list of package descriptors..." Right, makes sense as well. > Best, > > Eshel