From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse Date: Thu, 31 Aug 2023 10:51:52 +0800 Message-ID: <8734zzudo7.fsf@yahoo.com> References: <169344150641.11482.13012085201452768898@vcs2.savannah.gnu.org> <20230831002506.C0C6DC038B5@vcs2.savannah.gnu.org> <87il8wt52f.fsf@yahoo.com> <583ae120-d016-e9e8-2783-db21c1e018b8@gutov.dev> <87edjkt3sn.fsf@yahoo.com> <6c5251b1-c289-07cf-587d-013c781e31f5@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3590"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 04:52:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbXnH-0000hz-RT for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 04:52:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbXn0-00063W-0K; Wed, 30 Aug 2023 22:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbXmy-00061b-Fx for emacs-devel@gnu.org; Wed, 30 Aug 2023 22:52:08 -0400 Original-Received: from sonic303-20.consmr.mail.ne1.yahoo.com ([66.163.188.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbXmw-0006qX-Ac for emacs-devel@gnu.org; Wed, 30 Aug 2023 22:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693450323; bh=t9U7gghQ6UI/6aMkC+iNA/5AcROqGnNuCZiGsGzInS4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=BiwrTtYc2V06nf0v7Yd07tGmYQXoq1poKQgF8iigYxjXSMkT5ieM3vw61/sTMLtWuUkgJHGhAG3EIdUziAk4J7BvQOS1/Nk7GoFxX9TYjJ25jtxKGfNjUOXRmFXSHOWPRdwIZMy8sCbWWZhquPsyZ+zZzKJVdzMUTmQ6U7b0neV6jwn7ImIY4r4JbuzlIOqA+p0RDpGcGlqeTf/OC1vo6OkfEsAy3/dYKSmZrHJHLFqTaVQH6/MdIostFr+uJ+nEvju1DOtgRkETQTUChmUjRzmm6VyMlewxmbMxyuAroPF9xWUqGENjrjvsqZw5qm60CFsz9BGeT/AznjzzA3F5wQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693450323; bh=16fWQEAheBmdNLjvHGYsDMiIq1P+XUEozNDW6+Ir66J=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=YOEfaDKSPNfPSrUA1HcdcqZ1zsftK1SapW9JFyiTzgzP9GO8TgHo+2Ysw1ZvcMmYW01FaHt3TmtiTOL9o5l/RbJkLb61guFvNbZKmqdY9nR6CS58VbNivL4/Os8czHrhbnGrjm6A97uUavgDF4vXOjnXlao2ggCuyycmoCELzXJXbMSH12Y3goy3l0IDaOmWttCgC6sI5o6OM7xHi9SD9VNBPgvt7idFGVXqbXHZhSIrqq2eF8GW94xKPw++s8hNtbHtrZtDJ3x946Cze68V8TQuvaSeNPIkfNFZBIacszS1Sr0PWvlEB7SvUF2yE6lbKq507dNa5hdzIKdLdmFBvA== X-YMail-OSG: oBo3aswVM1ntTtwCiuadHVyK6vE.KfD6pD4J2P.FuTVVOhpC1lIw5LxpbKkvk51 8SFDI2aed6gNa53ppYsFFRgSzZflCOy01x_vN9TKJNTy5vURKtFxEsLjRMIc3uAnW_m5ZUF8ZOKp ppUu1.Xu7tDjzcvdgxl4uARK0C3BWuqrGIKZfzoHhwF2QDBplGvbQ3F2M6uVnH5DOw6q8Ssi7Wev 6F9EOAYtfPurjTMq3gLh7xPW_hRdFsWB9g2Rld7spiT5J1BkCjajNOrXLHGpvlOq7l6VQelb1H_k dLhJIkWk5IGE.vNPlHKBA5mVYZwg0InSfxQPmYq9tw__Y6vdYVULYfltUJmIKcapkWBf.RKaM8QL QwxCgWwbYtPUoHybbgBenLsW35hvy.z7yscPm8UPAo.yWeYFeSOiSaEjzNIdHVe4IPE.9B2TlqEg hltJyiNCbhYxLWHHBgxl9E68vE1uoNUlKGl0sPHwEJh_Ro1R9XaG_N2zJj_xQJVbzgKl_9PHJGYH 0flNA4DO055LPrymDzZcx290wfqLVwuo_4AZqAEnTYzNz.9PolLzCbNJh9zs_vXALIQNLPix9BbH 2eFnT__AfGilZmyPq04aHCdHuoXwTVNVZ8p09na.m526iHJ.J9LURzYpzUpPFOQ8pVa8MoQJSF4c 805RZv3flR2waHcT4F_rU3bhQ1l2VfpH2DrzafBs4Z8H23x8HipzSWU1F1uCxKvmbDdwjuaeGnz0 5Xwxc8oz4JCMTzTS_9dOUW3pwVIxOgIltKiRWzCIkM.aqZZHiXwDpT64_tPWkLBfIJM93ERy4zpe gaOn3fLYo93LQek47ZFSoOYoxPVke0HOY5teesC0sE X-Sonic-MF: X-Sonic-ID: 55158d4c-4c90-48b1-b1fd-454a9be28f23 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Thu, 31 Aug 2023 02:52:03 +0000 Original-Received: by hermes--production-sg3-69654d8bd-sv8qw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 178c4e70efefd1e4b2e287675dd9be59; Thu, 31 Aug 2023 02:51:59 +0000 (UTC) In-Reply-To: <6c5251b1-c289-07cf-587d-013c781e31f5@gutov.dev> (Dmitry Gutov's message of "Thu, 31 Aug 2023 05:05:50 +0300") X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.146; envelope-from=luangruo@yahoo.com; helo=sonic303-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309583 Archived-At: Dmitry Gutov writes: > Sorry, I'm still not seeing your point. Especially the last paragraph > in my last email seems to remain unaddressed. > > And both commands take EVENT as an argument already. > > The problem is not where is searched for an identifier, but *from > where* it searched for the identifier's locations. And that position > is important only for particular Xref backends (both LSP-based ones, > I'm assuming). My point is this: xref-find-definitions itself, not its callers, should take EVENT, then call (goto-char (posn-point (event-start event))) within.