From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman Newsgroups: gmane.emacs.devel Subject: Re: Treesit Regression In ec4d29c4494f32acf0ff7c5632a1d951d957f084 Date: Sun, 10 Sep 2023 00:00:07 -0400 Message-ID: <8734zm4qin.fsf@dfreeman.email> References: <87r0n7dt34.fsf@dfreeman.email> <68CFCC60-F71F-41E3-AF2A-E78E00EB3FD2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26038"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 10 06:11:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfBna-0006a5-8u for ged-emacs-devel@m.gmane-mx.org; Sun, 10 Sep 2023 06:11:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfBmg-0003Rn-6l; Sun, 10 Sep 2023 00:10:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfBmd-0003Ra-E4 for emacs-devel@gnu.org; Sun, 10 Sep 2023 00:10:52 -0400 Original-Received: from out-221.mta0.migadu.com ([91.218.175.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfBma-0006aJ-5D for emacs-devel@gnu.org; Sun, 10 Sep 2023 00:10:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1694319045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j96IcKtjQRTUNfd7IShk83SGmz/JpEnSLu/VcUP7pcI=; b=I5+SyYrEhiKN03Q+Wl1uD8X8LQtD5CdgtvQR0nK70Gizis/a2sjsrDqfcuEObWww6NvR8h s2UPoea4NTcexQSXgjDHHFEw4gZorUsFZWSBN9kdI89ILT2gdjqoWvgNiSAfLwu3YDkhN1 xjddq/wve19mUMSAcuHzHR3tIG04oqo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <68CFCC60-F71F-41E3-AF2A-E78E00EB3FD2@gmail.com> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.221; envelope-from=danny@dfreeman.email; helo=out-221.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310430 Archived-At: Yuan Fu writes: > > Hmmm, I can=E2=80=99t reproduce this. I=E2=80=99m getting > > Matched rule: ((parent-is "source") parent-bol 0) > Matched rule: (clojure-ts--match-expression-in-body parent 2) > > The commit you pointed to does change treesit-node-parent, so it does mat= ch with parent-is matcher not working. > > Might be because I recently upgraded to a newer tree-sitter library. If y= ou compile with the newest tree-sitter build (from their repo), do you stil= l see this problem? Before I was just using whatever tree-sitter version my distro packages. Apparently v0.20.8 (built from the git tag of the same name) I tried compiling with this version https://github.com/tree-sitter/tree-sitter/commit/524bf7e2c664d4a5dbd0c20d4= d10f1e58f99e8ce which at the time of writing is the latest, and still experience the same problem. I also made sure to re-compile my grammars. I may have done something wrong though when building. I'm going to try to build using a more traditional process rather than with nix and see if that helps. Thank you, --=20 Danny Freeman