From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Date: Sat, 30 Sep 2023 20:51:25 +0200 Message-ID: <8734yvbiky.fsf_-_@sappc2.fritz.box> References: <87o7uknkyx.fsf@gnus.org> <87fsfwnkl4.fsf@gnus.org> <87a663kxtz.fsf@gnus.org> <87czaygqqp.fsf@gnus.org> <87fsfte2hf.fsf@gnus.org> <87o7hod6dk.fsf@sappc2.fritz.box> <87v8bwip2h.fsf@sappc2.fritz.box> <87ttrcaqrm.fsf@sappc2.fritz.box> <83jzs7aga5.fsf@gnu.org> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37097"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: germanp82@hotmail.com, 58396@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, 58148@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 30 20:53:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmf5K-0009Gm-Tx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Sep 2023 20:53:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmf56-0002Jl-BC; Sat, 30 Sep 2023 14:52:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmf55-0002JT-09 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 14:52:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmf54-0000Mb-OF for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 14:52:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmf5K-0007CJ-81 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 14:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Sep 2023 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58148 X-GNU-PR-Package: emacs Original-Received: via spool by 58148-submit@debbugs.gnu.org id=B58148.169609993227595 (code B ref 58148); Sat, 30 Sep 2023 18:53:02 +0000 Original-Received: (at 58148) by debbugs.gnu.org; 30 Sep 2023 18:52:12 +0000 Original-Received: from localhost ([127.0.0.1]:59783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmf4W-0007Az-8X for submit@debbugs.gnu.org; Sat, 30 Sep 2023 14:52:12 -0400 Original-Received: from mr4.vodafonemail.de ([145.253.228.164]:36662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmf4T-0007Ah-PV; Sat, 30 Sep 2023 14:52:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1696099908; bh=PnTSORtmV5mnjx0TWe6/xc84i3Dg4JjnYMFPHv+Jcb0=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=etB6RbORq+LMG/7ES9ye+CZGu3DneR77t4D1U0YExm0tGFqIxsgu27flX6+C8i6np Myo7z64JyekoyvucLwMSotxZD1mvEscapJCzbS5egKToWzlAIcgY9711UEavDl/QaQ sspluzr81M3eULJZ9+9CWhoM2No0jkz6rucF2F6Q= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4Rybsw4qdwz1xwp; Sat, 30 Sep 2023 18:51:48 +0000 (UTC) Original-Received: from sappc2 (port-83-236-57-119.dynamic.as20676.net [83.236.57.119]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4RybsX6nXQzKm4S; Sat, 30 Sep 2023 18:51:25 +0000 (UTC) In-Reply-To: <83jzs7aga5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Sep 2023 17:26:26 +0300") X-purgate-type: clean X-purgate: clean X-purgate-size: 780 X-purgate-ID: 155817::1696099904-597FC58E-F147A9F6/2/54773152652 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271559 Archived-At: Eli Zaretskii writes: > Most of this comment should be in the commit log message, I think, and > the [1] and [3] markers should be replaced with text telling what that > does. Otherwise, the first patch is okay for the emacs-29 branch. Updated the patch accordingly and sent it on that other branch of this thread, please review. However, I removed the [1] and [3] markers without replacement: I don't think that there is much need to separately comment on a `condition-case' or a let-binding of `inhibit-message'. > Regarding the second patch: if Stefan Monnier and Stefan Kangas are > okay with it, so am I. Does that mean that I should explicitly draw Stefan Kangas' attention to this bug? Or would he notice somehow otherwise? Thanks.